Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
TinyMCE Improvements: Open links from note window with popup and auto-create links (for 4.0 branch) #450
Okay, here is an updated version for the 4.0 branch.
I have Moved the pull-request.
I tried but have problems doing this because I am unable to get the original event. Maybe you have an idea what's going on. Currently, the linksmenu plugin adds a command using
For me, two finger click on touchpad is right click (OSX/Firefox) and I can't reproduce the problem. So it would be great if you can take a look.
I remove the Unlink button from the toolbar.
I'll look into passing through the modifier keys and getting this to work in separate note windows.
For contextmenu, it looks like this will be easier once we upgrade to TinyMCE 4, which lets you define menu items that can then be added to the menu. In the meantime, we can just include the non-minified version from GitHub — I assume it's just this — and add a comment that says "// Added by Zotero".
I can look into it.
Otherwise, this looks good. You can squash these commits together into a single one for merging.
Sorry, could you just clean up that commit message a little and remove unnecessary stuff ("Indent correctly")? You can use
Also, can you add a comment to the top of linksmenu/editor_plugin.js saying that it's based on the TinyMCE contextmenu plugin (which I think is what you said)?
Sorry, my git skills are still pretty bad. The message is fixed.
There already is a comment saying
* This plugin adds a left-click context menu to links in the TinyMCE editor for Zotero. * Code adopted and modified from TinyMCE contextmenu plugin.
Sorry, missed that.
Merged into 4.0. Note that I rebased your commit again to convert spaces to tabs (which are what we use) in linksmenu/editor_plugin.js, so you'll probably need to rewind to before these changes with
Thanks for working on this!