fix copy/paste of non-http links in Notes #452

Merged
merged 1 commit into from Feb 5, 2014

Projects

None yet

2 participants

@jlegewie
Contributor
jlegewie commented Feb 5, 2014

Hi,
copy+paste within notes removes non-http links. So the html code <a href="zotero://select/items/0_DQHBAGPE">link</a> becomes <a>link</a> when I copy and paste it within notes. http links, however, work without a problem. It's probably some obscure tinymce bug. It works in Chrome but it doesn't in firefox. This pull request fixes the bug with a small addition in the paste plugin. I had to replace the minified version with the full one and then changed the part which is earmarked with an // Added by Zotero.

@dstillman dstillman merged commit 8b6cedd into zotero:4.0 Feb 5, 2014
@dstillman
Member

Thanks!

@dstillman dstillman added a commit that referenced this pull request Apr 10, 2015
@dstillman dstillman Fix pasting of non-HTTP URLs into notes from non-note sources
Copying zotero:// and other non-HTTP links from a note itself was fixed
in #452, but copying such links from other sources still stripped the
hrefs. This removes the patch in #452 and just gets the HTML directly
from the clipboard. I'm not sure why TinyMCE doesn't try to do this by
default (it only tries for plaintext), so maybe there's a problem with
this approach, but it seems to work for me (strips bad HTML, etc.).

Fixes #697
b599aed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment