New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leap year error during static files request. #1202

Closed
LilDash opened this Issue Feb 29, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@LilDash
Contributor

LilDash commented Feb 29, 2016

Zotonic crashed with this error: {badarg,[{erlang,universaltime_to_localtime,[{{2017,2,29},{2,13,1}}],[]}

The code : {{{Y+1,M,D},HIS}, ReqData, State}; in the controller_file.erl(line 105) makes leap year error during static files request.

LilDash added a commit to LilDash/zotonic that referenced this issue Feb 29, 2016

Fix the leap year error(issue : zotonic#1202)
Fix the leap year error during static files request.
@mworrell

This comment has been minimized.

Member

mworrell commented Feb 29, 2016

Wow, that its embarrassing. Thanks for the fix!

@mworrell mworrell added this to the Release 0.13.8 milestone Feb 29, 2016

mworrell added a commit that referenced this issue Feb 29, 2016

Merge pull request #1203 from LilDash/patch-1
Fix the leap year error(issue : #1202)

mworrell added a commit that referenced this issue Feb 29, 2016

Fix the leap year error(issue : #1202)
Fix the leap year error during static files request.
(cherry picked from commit 098cfa4)

mworrell added a commit that referenced this issue Feb 29, 2016

Fix the leap year error(issue : #1202)
Fix the leap year error during static files request.
(cherry picked from commit 098cfa4)

mworrell added a commit that referenced this issue Feb 29, 2016

Fix the leap year error(issue : #1202)
Fix the leap year error during static files request.
(cherry picked from commit 098cfa4)

ddeboer added a commit that referenced this issue Feb 29, 2016

Fix the leap year error(issue : #1202)
Fix the leap year error during static files request.
@mworrell

This comment has been minimized.

Member

mworrell commented Feb 29, 2016

A hotfix release was made to handle this issue https://github.com/zotonic/zotonic/releases/tag/0.13.8

@mworrell mworrell added the defect label Feb 29, 2016

@mworrell

This comment has been minimized.

Member

mworrell commented Feb 29, 2016

@LilDash Thanks again for reporting and fixing this.

@mworrell mworrell closed this Feb 29, 2016

@LilDash

This comment has been minimized.

Contributor

LilDash commented Feb 29, 2016

my pleasure : )

ddeboer pushed a commit to ddeboer/zotonic that referenced this issue May 16, 2017

Fix the leap year error(issue : zotonic#1202)
Fix the leap year error during static files request.
(cherry picked from commit 957a4a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment