Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a resource requires insert permission on its category #1229

Closed
ddeboer opened this issue Mar 30, 2016 · 8 comments
Closed

Updating a resource requires insert permission on its category #1229

ddeboer opened this issue Mar 30, 2016 · 8 comments
Assignees
Milestone

Comments

@ddeboer
Copy link
Member

@ddeboer ddeboer commented Mar 30, 2016

Because of can_insert_category. Why is that check there? Is it because we often don’t differentiate between insert and update?

This is similar to #1125.

@ddeboer ddeboer added this to the 0.16 milestone Mar 30, 2016
@mworrell

This comment has been minimized.

Copy link
Member

@mworrell mworrell commented Mar 30, 2016

We have to check where it is used and might need to differentiate between insert and update (those are indeed different actions in the ACL, so should be checked different)

@ddeboer

This comment has been minimized.

Copy link
Member Author

@ddeboer ddeboer commented Mar 30, 2016

So we need to add some can_update_category or can_category, right?

@mworrell

This comment has been minimized.

Copy link
Member

@mworrell mworrell commented Mar 31, 2016

I will check how this is used and tune it.

@mworrell mworrell self-assigned this Mar 31, 2016
@ddeboer

This comment has been minimized.

Copy link
Member Author

@ddeboer ddeboer commented Mar 31, 2016

Awesome!

mworrell added a commit that referenced this issue Mar 31, 2016
@mworrell

This comment has been minimized.

Copy link
Member

@mworrell mworrell commented Mar 31, 2016

@ddeboer can you check branch issue-1229-acl-update-check ?

@ddeboer

This comment has been minimized.

Copy link
Member Author

@ddeboer ddeboer commented Mar 31, 2016

Will do, please open a PR, as that makes commenting easier.

@mworrell

This comment has been minimized.

Copy link
Member

@mworrell mworrell commented Mar 31, 2016

See #1232

mworrell added a commit that referenced this issue Apr 11, 2016
…rly during rsc updates. Issue #1229
mworrell added a commit that referenced this issue Apr 13, 2016
…rly during rsc updates. Issue #1229
mworrell added a commit that referenced this issue Apr 13, 2016
mworrell added a commit that referenced this issue Apr 13, 2016
…rly during rsc updates. Issue #1229

(cherry picked from commit 9fb8fee)
@mworrell

This comment has been minimized.

Copy link
Member

@mworrell mworrell commented Apr 13, 2016

This has been merged.

@mworrell mworrell closed this Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.