Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make slug and seo fields translatable #1911

Merged
merged 1 commit into from May 31, 2018
Merged

Make slug and seo fields translatable #1911

merged 1 commit into from May 31, 2018

Conversation

mworrell
Copy link
Member

Description

Issue #1095

Makes the slug and seo fields translatable.

No BC breaks, afaik. Unless the fields are exported in JSON, as the values are now {trans, ...} records.

Checklist

  • documentation updated
  • tests added
  • no BC breaks

@mworrell mworrell requested a review from ddeboer May 28, 2018 11:11
@ddeboer
Copy link
Member

ddeboer commented May 31, 2018

This actually fixes #1095, doesn’t it?

@mworrell
Copy link
Member Author

This fixes only the slug part of #1095, not the page_path and name part.

The page_path is a tad more complicate (due to 1:n and also language mapping).
The name part needs changes in the tokenizer of the templates, otherwise you can't refer to those names.

@ddeboer ddeboer merged commit 1b17dd5 into 0.x May 31, 2018
@ddeboer ddeboer deleted the 1095-slug-translate branch May 31, 2018 14:11
@ddeboer ddeboer added this to the 0.40 milestone May 31, 2018
ddeboer pushed a commit that referenced this pull request May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants