Any other parametrized modules around?
Erlydtl can do parameterized module variable lookups, but I see that the erlydtl compiler does not use them. So I guess that doesn't count.
We just remove that from the runtime
Need to investigate what the update to MochiWeb is - if it removes parametrized modules or adds some parse transforms as an intermediate solution.
For webzmachine I see a wm_resource.hrl on the horizon... and a couple of small rewrites... Not too bad. Or do we call it wm_controller.hrl to bring it more in line with zotonic's naming conventions.
And for mochiweb... oops... that is quite some work...
You mentioned moving to either cowboy or https://github.com/knutin/elli Maybe that moving to a different base http server is a better option if we have to invest a considerable amount of time into this.
Looking through their repo's their github repo's I kind of like the minimal approach of elli. I have the gut feeling that webzmachine + elli would mix very well. But that is just based on gut feeling and nothing else. At least elli knows that one SHOULD use properly capitalized http headers. :-)
+1 for elli, also no real know-why.. only looked through the code, and liked what I saw :)
Cleaned up webzmachine.
Now, who will do the elli thing....
Removed last webzmachine specific parametrized module.
Created new ticket for this, #533
core: remove some more parametrized module references. Issue #513
Reopening, since this issue is about getting rid of the parametrized modules, and not about replacing mochiweb with elli.
We can close this one when we are running on R16B
I propose to (for now) add the parametrized-module-parse-transform to MochiWeb.
I don't think they use the parse transform.. see this commit mochi/mochiweb@23a1d48
I would like to pull their changes into our zotonic/mochiweb.
Merged branch mochi/mochiweb@f3f133b from mochiweb in our version.
Our changes (compared to origin) amount to:
We can now start testing on R16
what about making pull requests upstream for these changes?
It seems they are pretty universal.
We will need some shaving on the any/any6 differences, and testing with the socket options.
Other than that, they seem to be quite ready to be merged upstream.
Will make separate issue in zotonic/mochiweb for that.
Back ref: zotonic/mochiweb#2
I am not aware of any other parametrized modules in Zotonic.
Closing this issue (reopen if we find some other parametrized modules)
(cherry picked from commit 99325a1)