Category tree cannot be edited when mod_menu is disabled #670

Closed
arjan opened this Issue Oct 3, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@arjan
Member

arjan commented Oct 3, 2013

This dependency between these similar interfaces is logical but I think the shared code should be included in another module, maybe just in mod_admin?

@ghost ghost assigned mworrell Oct 3, 2013

@mworrell

This comment has been minimized.

Show comment
Hide comment
@mworrell

mworrell Oct 3, 2013

Member

The mod_menu is quite some code, and templates, that is not depending on anything else.
I prefer strongly to keep it separate.

As mod_menu isn't blocking anything, just adding functionality, we can add a dependency on 'menu' and add 'menu' as a provided service to mod_menu.

In that way you can still add other menu code, if you want to.

Member

mworrell commented Oct 3, 2013

The mod_menu is quite some code, and templates, that is not depending on anything else.
I prefer strongly to keep it separate.

As mod_menu isn't blocking anything, just adding functionality, we can add a dependency on 'menu' and add 'menu' as a provided service to mod_menu.

In that way you can still add other menu code, if you want to.

@kaos

This comment has been minimized.

Show comment
Hide comment
@kaos

kaos Oct 3, 2013

Member

Well, I agree with arjan here, that it's somewhat backwards that mod_admin_category relies on functionality provided by mod_menu: https://github.com/zotonic/zotonic/blob/master/modules/mod_admin_category/templates/_admin_category_sorter.tpl#L6

Wouldn't it be better to factor out the generic sorting code in mod_menu to a common module (why not mod_base? so it can be used from any site as well)?

Member

kaos commented Oct 3, 2013

Well, I agree with arjan here, that it's somewhat backwards that mod_admin_category relies on functionality provided by mod_menu: https://github.com/zotonic/zotonic/blob/master/modules/mod_admin_category/templates/_admin_category_sorter.tpl#L6

Wouldn't it be better to factor out the generic sorting code in mod_menu to a common module (why not mod_base? so it can be used from any site as well)?

@mworrell

This comment has been minimized.

Show comment
Hide comment
@mworrell

mworrell Oct 3, 2013

Member

Then it would be mod_admin_menu

mod_base holds already a lot of code, and I think it should gear primarily to support the anonymous-user-visiting-a-site use-case.

Member

mworrell commented Oct 3, 2013

Then it would be mod_admin_menu

mod_base holds already a lot of code, and I think it should gear primarily to support the anonymous-user-visiting-a-site use-case.

@kaos

This comment has been minimized.

Show comment
Hide comment
@kaos

kaos Oct 3, 2013

Member

Ok, it makes sense to keep mod_base as slim as possible.

mod_admin_menu?

Member

kaos commented Oct 3, 2013

Ok, it makes sense to keep mod_base as slim as possible.

mod_admin_menu?

@arjan arjan closed this in acf8c49 Apr 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment