Skip to content

Category tree cannot be edited when mod_menu is disabled #670

Closed
arjan opened this Issue Oct 3, 2013 · 4 comments

3 participants

@arjan
Zotonic member
arjan commented Oct 3, 2013

This dependency between these similar interfaces is logical but I think the shared code should be included in another module, maybe just in mod_admin?

@mworrell mworrell was assigned Oct 3, 2013
@mworrell
Zotonic member
mworrell commented Oct 3, 2013

The mod_menu is quite some code, and templates, that is not depending on anything else.
I prefer strongly to keep it separate.

As mod_menu isn't blocking anything, just adding functionality, we can add a dependency on 'menu' and add 'menu' as a provided service to mod_menu.

In that way you can still add other menu code, if you want to.

@kaos
Zotonic member
kaos commented Oct 3, 2013

Well, I agree with arjan here, that it's somewhat backwards that mod_admin_category relies on functionality provided by mod_menu: https://github.com/zotonic/zotonic/blob/master/modules/mod_admin_category/templates/_admin_category_sorter.tpl#L6

Wouldn't it be better to factor out the generic sorting code in mod_menu to a common module (why not mod_base? so it can be used from any site as well)?

@mworrell
Zotonic member
mworrell commented Oct 3, 2013

Then it would be mod_admin_menu

mod_base holds already a lot of code, and I think it should gear primarily to support the anonymous-user-visiting-a-site use-case.

@kaos
Zotonic member
kaos commented Oct 3, 2013

Ok, it makes sense to keep mod_base as slim as possible.

mod_admin_menu?

@arjan arjan added a commit that closed this issue Apr 17, 2014
@arjan arjan mod_admin_category: Add dependency to mod_menu
And update documentation which explains this dependency.

Fixes #670
acf8c49
@arjan arjan closed this in acf8c49 Apr 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.