New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain reqdata for use in #dispatch_host notification #1664

Merged
merged 2 commits into from Apr 13, 2017

Conversation

Projects
None yet
4 participants
@Dirklectisch
Contributor

Dirklectisch commented Apr 13, 2017

This is a small fix for missing request data when observing #dispatch_host.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 13, 2017

@Dirklectisch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mworrell, @ddeboer and @arjan to be potential reviewers.

mention-bot commented Apr 13, 2017

@Dirklectisch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mworrell, @ddeboer and @arjan to be potential reviewers.

@mworrell

This comment has been minimized.

Show comment
Hide comment
@mworrell

mworrell Apr 13, 2017

Member

I made a similar change in the master 588a903

Can you fix your merge request?

Member

mworrell commented Apr 13, 2017

I made a similar change in the master 588a903

Can you fix your merge request?

@mworrell

The z_context:new/1 call should be inside the catch expression.
You should use z_context:set_reqdata(ReqData, z_context:new(Site))) here.

Show outdated Hide outdated src/support/z_sites_dispatcher.erl Outdated
@Dirklectisch

This comment has been minimized.

Show comment
Hide comment
@Dirklectisch

Dirklectisch Apr 13, 2017

Contributor

Updated with your suggestion.

Contributor

Dirklectisch commented Apr 13, 2017

Updated with your suggestion.

@mworrell mworrell merged commit be13103 into zotonic:0.x Apr 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mworrell

This comment has been minimized.

Show comment
Hide comment
@mworrell

mworrell Apr 13, 2017

Member

Thanks!

Member

mworrell commented Apr 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment