z_config: report config file parse errors, and terminate. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This satisfies "We should add some pre-flight/sanity checks to the config parser and fail with clear messages." from issue zotonic#5. Sample error message (in this case, a missing comma): =ERROR REPORT==== 19-Oct-2011::16:52:52 === z_config:122 failed to parse: /opt/zotonic/priv/config: 38: syntax error before: '{'
|
Looks good to me. Thanks for the patch! |
mworrell
added a commit
that referenced
this pull request
Oct 19, 2011
…g_parse_error z_config: report config file parse errors, and terminate. Refers to issue #5.
rpip
pushed a commit
to rpip/zotonic
that referenced
this pull request
Aug 12, 2013
…n_config_parse_error z_config: report config file parse errors, and terminate. Refers to issue zotonic#5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This satisfies "We should add some pre-flight/sanity checks to the config parser and fail with clear messages." from issue #5.
Sample error message (in this case, a missing comma):
=ERROR REPORT==== 19-Oct-2011::16:52:52 ===
z_config:122 failed to parse: /opt/zotonic/priv/config: 38: syntax error before: '{'