Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added missing .pot files, translated hardcoded strings in modules and completed Spanish translation #3

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants

There are lost of little changes in this pull request. I've added sme .pot files that were not being generated. I also went over most of the strings in the modules and templates and translated in the same way I saw you were doing it in other places. I also fixed some English strings and completed the Spanish translation.

There are lots of changes here. Next time if you want I can make lots of small commits.

I've tested practically all of the translations on my local Zotonic installation.

Owner

arjan commented Aug 13, 2011

Thanks for the changes!

There's actually one thing that I don't like: the way the translations are done in the .erl files.
can you change that to the way it's being done in support/z_datetime.erl?

e.g. using the
?__(<<"some string here">>,Context)

construct.

and then putting the spanish translations of those english texts in a special .po file (since we dont can scan yet for these constructs). I would make that .po file per module and put it in e.g. modules/mod_admin/translations/es.erl.po for the strings coming from .erl files from mod_admin.

Owner

arjan commented Aug 14, 2011

Hi,

I actually fixed the .erl file scanning. All modules now get scanned for ?__("some string here",Context) constructs and those strings are put in translation files. So you can disregard the last paragraph from my last comment

If I understand this correctly, the only thing I'd have to do is go over all the strings that need to be translated in the .erl files and change them to the ?__() format you specified before, right? Once this is done I'd have to regenerate all the .pot files and add the missing Spanish translations.

Is my interpretation of what you said OK?

Owner

arjan commented Aug 16, 2011

Yes, exactly like that :-)

Owner

arjan commented Aug 16, 2011

And we'll switch to git in a few weeks when I'm back from holiday, so that makes it easier in the future to do these pull requests :)

Owner

arjan commented Sep 5, 2011

We've switched to git now :-) Are you still working on this? Maybe you need to create a new branch.

Yes, I'm still working on it, but I got sidetracked with "real work". I will create a new branch based on the master branch on github and recommit my changes. It will take me 2 o3 days to find time to finish this, though.

Owner

mworrell commented Oct 4, 2011

Hi,

How is it going? If you had any time then I would be more than happy to merge your changes.
(I know that time is sometimes hard to find, don't feel pressed :)

  • Marc

Sorry, I've been swamped by Real Work. I think I'll have some time tomorrow and be able to finish the translations and integrate everything with HEAD.

@jcomellas jcomellas closed this Oct 20, 2011

@jcomellas jcomellas reopened this Oct 20, 2011

Owner

mworrell commented Oct 20, 2011

Thanks. Take care, it is better to do things good and slower than to push yourself too hard :)

Owner

arjan commented Jan 2, 2013

Closing this PR again... Not yet in a mergeable state.

@jcomellas feel free to reopen whenever you have it finished again.

@arjan arjan closed this Jan 2, 2013

mmzeeman added a commit that referenced this pull request Mar 14, 2013

rpip pushed a commit to rpip/zotonic that referenced this pull request Aug 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment