Allow configuration of addresses without a mask/prefix #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will assume an implicit host address (32-bit/128-bit mask/prefix).
Prior to this change, it was necessary to explicitly pass a mask:
addr/mask:port
This has caused confusion among some users [1, 2], who assume no mask
would imply a /32.
This patch allows the configuration of host addresses (with no mask
explicitly declared):
# adr/mask:port type proto owner name nfail disable
[remote]
192.0.2.1:ssh * * * = * *
Is now equivalent to:
# adr/mask:port type proto owner name nfail disable
[remote]
192.0.2.1/32:ssh * * * = * *
Obtained from: [1]
[1]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164
[2]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247309
|
Not necessarily a pull request, as this patch is not on FreeBSD. It is proposed here for your consideration. |
|
committed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will assume an implicit host address (32-bit/128-bit mask/prefix).
Prior to this change, it was necessary to explicitly pass a mask:
This has caused confusion among some users 12, who assume no mask would imply a /32.
This patch allows the configuration of host addresses (with no mask explicitly declared):
Is now equivalent to:
Obtained from: 1
Footnotes
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243164 ↩ ↩2
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247309 ↩