Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accommodating keystore parameters with spaces #1676

Merged
merged 2 commits into from Aug 5, 2021

Conversation

1000TurquoisePogs
Copy link
Member

Recreation of #1664 for using branch without fork.

Description

Recently we've seen users that have spaces in their keystore such that $KEY_ALIAS could be misinterpreted.
A solution is to put quotes around the parameters, and that's what was done successfully in the web explorers such as here https://github.com/zowe/explorer-jes/blob/master/bin/start.sh#L47-L52
I tried to find all occurrences of variables that might need spaces, though perhaps having quotes everywhere is not a bad idea.

Type of change

Please delete options that are not relevant.

  • (fix) Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

I'll run the automated tests on this to see how it does.

…e spaces in the values

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@1000TurquoisePogs 1000TurquoisePogs changed the title Accommodating keystore parameters with spaces fix: Accommodating keystore parameters with spaces Aug 4, 2021
@1000TurquoisePogs 1000TurquoisePogs requested a review from a team August 4, 2021 19:44
@1000TurquoisePogs
Copy link
Member Author

Looks like my changes passed every test except one just because it doesnt work with my username, probably.

@balhar-jakub balhar-jakub merged commit a784d26 into master Aug 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix/certs-with-spaces branch August 5, 2021 07:04
@balhar-jakub
Copy link
Member

Thanks for spotting and fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants