Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service still displayed as UP and API doc available in the catalog even if stopped #287

Merged
merged 5 commits into from May 28, 2019

Conversation

@ilkinabdullayev
Copy link
Collaborator

commented Apr 15, 2019

Issue #283
Hi Reviewers!
In this PR, I have implemented 2 things.

  1. The first problem is service still displayed as UP even if stopped. Actually, it had been working before, it was broken after #262 implementation. I grabbed old implementation codes and I made refactoring a little bit.
  2. The second part is totally new. When service is down, api-doc should be gotten from the URL otherwise it should be from the cache.

I apologize for what you see as changes. It was hard to decide a better design. I hope you will enjoy!

@JirkaAichler
Copy link
Collaborator

left a comment

Looks good as always!

Will approve it once it passes IT tests. Please let me know.

@ilkinabdullayev ilkinabdullayev force-pushed the private/abdil01/retrival-problem branch 10 times, most recently from b2b4261 to e919fed May 21, 2019

@codecov

This comment has been minimized.

Copy link

commented May 22, 2019

Codecov Report

Merging #287 into master will decrease coverage by 10.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #287       +/-   ##
============================================
- Coverage     69.35%   59.2%   -10.16%     
============================================
  Files           234      40      -194     
  Lines          4493     701     -3792     
  Branches        569     207      -362     
============================================
- Hits           3116     415     -2701     
+ Misses         1223     286      -937     
+ Partials        154       0      -154
Impacted Files Coverage Δ Complexity Δ
...oduct/registry/CannotRegisterServiceException.java
...tatus/listeners/AppContextInitialisedListener.java
...service/client/impl/ApimlEurekaInstanceConfig.java
...m/ca/mfaas/client/service/impl/PetServiceImpl.java
...gateway/security/config/SecurityConfiguration.java
...om/ca/mfaas/gateway/error/check/TlsErrorCheck.java
...eway/security/query/TokenNotProvidedException.java
...ca/mfaas/gateway/ws/WebSocketActuatorEndpoint.java
...talog/controllers/api/CatalogApiDocController.java
...a/mfaas/gateway/error/check/TimeoutErrorCheck.java
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473d247...40c7443. Read the comment docs.

@taban03
Copy link
Collaborator

left a comment

It looks good Ilkin, thank you!

@JirkaAichler

This comment has been minimized.

Copy link
Collaborator

commented May 23, 2019

Please, could you change the following messages to debug?

2019-05-23 10:01:41.696 INFO 22204 --- [pool-8-thread-1] c.c.m.a.s.cached.CacheRefreshService : Created/Updated tile and updated cache for container: zosmf @ Thu May 23 10:01:41 CEST 2019

@ilkinabdullayev ilkinabdullayev force-pushed the private/abdil01/retrival-problem branch 3 times, most recently from 453d64e to 1c6497e May 27, 2019

@JirkaAichler
Copy link
Collaborator

left a comment

Very nice!

@taban03 taban03 self-requested a review May 28, 2019

@ilkinabdullayev ilkinabdullayev merged commit ef4e356 into master May 28, 2019

5 checks passed

DCO DCO
Details
WIP Ready for review
Details
codecov/patch Coverage not affected when comparing 473d247...40c7443
Details
codecov/project 59.2% (target 55%)
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@delete-merged-branch delete-merged-branch bot deleted the private/abdil01/retrival-problem branch May 28, 2019

cZikos pushed a commit that referenced this pull request May 30, 2019

Service still displayed as UP and API doc available in the catalog ev…
…en if stopped (#287)

* Changed cache strategy and  implementation of api-doc cache

Signed-off-by: Ilkin Abdullayev <ilkin.abdullayev@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.