Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency of integration-enabler-java on gateway-common #302

Merged
merged 4 commits into from May 7, 2019

Conversation

@plavjanik
Copy link
Collaborator

commented May 7, 2019

Resolves #301

The gateway-common is a Spring Boot application that is using Spring Boot enabler. Its inclusion in integration-enabler-java has caused two active enablers in one. ApiInfo has been moved to integration-enabler-java. integration-enabler-java is used gateway-common now so ApiInfo is shared. integration-enabler-java is not activated Spring-automagically so it can be a dependency of gateway-common.

@ghost ghost assigned plavjanik May 7, 2019

@ghost ghost added the review label May 7, 2019

@plavjanik plavjanik changed the title Remove dependency of integration-enabler-java on gateway-common WIP - Remove dependency of integration-enabler-java on gateway-common May 7, 2019

@JirkaAichler
Copy link
Collaborator

left a comment

Thank you Petr for fixing it!
Have you moved ApiInfoTest as well?

@codecov

This comment has been minimized.

Copy link

commented May 7, 2019

Codecov Report

Merging #302 into master will decrease coverage by 1.82%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #302      +/-   ##
============================================
- Coverage        69%   67.17%   -1.83%     
  Complexity       12       12              
============================================
  Files           239      205      -34     
  Lines          4884     3945     -939     
  Branches        643      532     -111     
============================================
- Hits           3370     2650     -720     
+ Misses         1350     1160     -190     
+ Partials        164      135      -29
Impacted Files Coverage Δ Complexity Δ
...atalog/services/status/APIDocRetrievalService.java 95.16% <ø> (ø) 0 <0> (ø) ⬇️
...iscovery/staticdef/ServiceDefinitionProcessor.java 90.9% <ø> (ø) 0 <0> (ø) ⬇️
...apicatalog/swagger/SubstituteSwaggerGenerator.java 90.9% <ø> (ø) 0 <0> (ø) ⬇️
...faas/apicatalog/metadata/EurekaMetadataParser.java 91.89% <ø> (ø) 0 <0> (ø) ⬇️
...aas/apicatalog/swagger/TransformApiDocService.java 94.93% <ø> (ø) 0 <0> (ø) ⬇️
...java/com/ca/mfaas/eurekaservice/model/ApiInfo.java 100% <100%> (+62.5%) 0 <0> (ø) ⬇️
...ekaservice/client/impl/ApiMediationClientImpl.java 97.61% <100%> (-0.52%) 0 <0> (ø)
...s/gateway/error/check/SecurityTokenErrorCheck.java 35.71% <0%> (-40.48%) 0% <0%> (ø)
...m/ca/mfaas/gateway/filters/pre/LocationFilter.java 83.33% <0%> (-16.67%) 0% <0%> (ø)
.../com/ca/mfaas/gateway/filters/pre/ZosmfFilter.java 88.88% <0%> (-7.78%) 0% <0%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e2638f...1d8b9cf. Read the comment docs.

@plavjanik plavjanik changed the title WIP - Remove dependency of integration-enabler-java on gateway-common Remove dependency of integration-enabler-java on gateway-common May 7, 2019

@plavjanik

This comment has been minimized.

Copy link
Collaborator Author

commented May 7, 2019

@JirkaAichler I forgot. It is fixed now. Thank you

@JirkaAichler
Copy link
Collaborator

left a comment

Thank you Petr for fixing my bug!

@ilkinabdullayev
Copy link
Collaborator

left a comment

Thanks Petr!

@plavjanik plavjanik merged commit ca1f9f2 into master May 7, 2019

3 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@ghost ghost removed the review label May 7, 2019

@plavjanik plavjanik deleted the fix-extra-registration branch May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.