Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gateway api-doc #305

Merged
merged 7 commits into from May 21, 2019

Conversation

@JirkaAichler
Copy link
Collaborator

commented May 15, 2019

Changes:

  • Gateway api-doc is present in Catalog
  • Fix bug when JSON response was not set correctly when unauthenticated
  • Fix error messages when a home page cannot be modified

Review:

  • Make sure that swagger file is correct
  • Double check ComponentScan for Gateway

@JirkaAichler JirkaAichler requested review from arxioly and ilkinabdullayev May 15, 2019

@ghost ghost assigned JirkaAichler May 15, 2019

@ghost ghost added the review label May 15, 2019

@codecov

This comment has been minimized.

Copy link

commented May 15, 2019

Codecov Report

Merging #305 into master will decrease coverage by 0.06%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #305      +/-   ##
============================================
- Coverage     69.42%   69.35%   -0.07%     
  Complexity       12       12              
============================================
  Files           235      234       -1     
  Lines          4500     4493       -7     
  Branches        568      569       +1     
============================================
- Hits           3124     3116       -8     
  Misses         1223     1223              
- Partials        153      154       +1
Impacted Files Coverage Δ Complexity Δ
.../java/com/ca/mfaas/gateway/GatewayApplication.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...as/product/routing/transform/TransformService.java 100% <100%> (ø) 0 <0> (ø) ⬇️
.../gateway/security/handler/UnauthorizedHandler.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...og/services/cached/CachedProductFamilyService.java 86.33% <83.33%> (-0.2%) 0 <0> (ø)
...va/com/ca/mfaas/apicatalog/model/APIContainer.java 96.87% <0%> (-3.13%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb72e6...9e0904d. Read the comment docs.

JirkaAichler and others added some commits May 15, 2019

Add Gateway api-doc
Signed-off-by: JirkaAichler <jiri.aichler@broadcom.com>
Update component scan
Fix warning message

Signed-off-by: JirkaAichler <jiri.aichler@broadcom.com>
Fix e2e test for homepage
Signed-off-by: Andrea Tabone <andrea.tabone@ca.com>
Fix another e2e test
Signed-off-by: Andrea Tabone <andrea.tabone@ca.com>
Update gateway-api-doc.json
As agreed. Please approve.
Fix text
Signed-off-by: JirkaAichler <jiri.aichler@broadcom.com>
@ilkinabdullayev
Copy link
Collaborator

left a comment

Great work!

@JirkaAichler JirkaAichler merged commit 523121e into master May 21, 2019

5 checks passed

DCO DCO
Details
WIP Ready for review
Details
codecov/patch 90% of diff hit (target 60%)
Details
codecov/project 69.35% (target 55%)
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@JirkaAichler JirkaAichler deleted the private/aicji01/gateway-swagger branch May 21, 2019

cZikos pushed a commit that referenced this pull request May 23, 2019

Add Gateway api-doc (#305)
* Add Gateway api-doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.