Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test for Gateway information #309

Merged
merged 1 commit into from May 22, 2019

Conversation

@taban03
Copy link
Collaborator

commented May 21, 2019

Add new e2e test to check that Gateway information are displayed correctly in the API Catalog detail page.

Signed-off-by: Andrea Tabone andrea.tabone@ca.com

@taban03 taban03 requested a review from ilkinabdullayev May 21, 2019

@taban03 taban03 self-assigned this May 21, 2019

@taban03 taban03 requested a review from jandadav May 21, 2019

Create a new e2e test for GW and update detail service tile
Signed-off-by: Andrea Tabone <andrea.tabone@ca.com>

@taban03 taban03 force-pushed the private/taban03/e2e_tests branch from f7de62e to 07c2a49 May 21, 2019

@taban03 taban03 requested a review from vsev0lod May 21, 2019

@codecov

This comment has been minimized.

Copy link

commented May 22, 2019

Codecov Report

Merging #309 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #309      +/-   ##
============================================
- Coverage     70.09%   69.35%   -0.75%     
  Complexity       12       12              
============================================
  Files           234      234              
  Lines          4612     4493     -119     
  Branches        587      569      -18     
============================================
- Hits           3233     3116     -117     
- Misses         1222     1223       +1     
+ Partials        157      154       -3
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/ca/mfaas/security/HttpsFactory.java 72.22% <0%> (-8.83%) 0% <0%> (ø)
...curity/config/SecurityConfigurationProperties.java 93.33% <0%> (-1.12%) 0% <0%> (ø)
...ateway/security/service/AuthenticationService.java 93.42% <0%> (-0.98%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523121e...07c2a49. Read the comment docs.

@taban03 taban03 merged commit 55a9945 into master May 22, 2019

5 checks passed

DCO DCO
Details
WIP Ready for review
Details
codecov/patch Coverage not affected when comparing 523121e...07c2a49
Details
codecov/project 69.35% (target 55%)
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

cZikos pushed a commit that referenced this pull request May 23, 2019

Create a new e2e test for GW and update detail service tile (#309)
Signed-off-by: Andrea Tabone <andrea.tabone@ca.com>

@taban03 taban03 deleted the private/taban03/e2e_tests branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.