Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove credential eureka #313

Merged
merged 9 commits into from May 30, 2019

Conversation

@ilkinabdullayev
Copy link
Collaborator

commented May 29, 2019

No description provided.

@arxioly arxioly force-pushed the remove-credential-eureka branch from 17ce839 to 072fc0c May 29, 2019

@codecov

This comment has been minimized.

Copy link

commented May 30, 2019

Codecov Report

Merging #313 into master will increase coverage by 0.63%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #313      +/-   ##
===========================================
+ Coverage     68.67%   69.3%   +0.63%     
  Complexity       12      12              
===========================================
  Files           235     235              
  Lines          4542    4486      -56     
  Branches        576     567       -9     
===========================================
- Hits           3119    3109      -10     
+ Misses         1272    1224      -48     
- Partials        151     153       +2
Impacted Files Coverage Δ Complexity Δ
.../discovery/config/EurekaSecurityConfiguration.java 57.14% <0%> (+3.8%) 0 <0> (ø) ⬇️
...overy/config/HttpsEurekaSecurityConfiguration.java 0% <0%> (ø) 0 <0> (?)
.../main/java/com/ca/mfaas/security/HttpsFactory.java 72.22% <0%> (-3.48%) 0% <0%> (ø)
...java/com/ca/mfaas/security/token/TokenService.java 78.37% <0%> (-2.22%) 0% <0%> (ø)
...curity/config/SecurityConfigurationProperties.java 93.33% <0%> (ø) 0% <0%> (ø) ⬇️
...curity/config/SecurityConfigurationProperties.java 92.3% <0%> (ø) 0% <0%> (ø) ⬇️
...main/java/com/ca/mfaas/product/web/HttpConfig.java 74.35% <0%> (ø) 0% <0%> (ø) ⬇️
...a/mfaas/security/token/JwtSecurityInitializer.java
...teway/security/service/JwtSecurityInitializer.java
...main/java/com/ca/mfaas/security/SecurityUtils.java
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4e356...b47b32a. Read the comment docs.

@JirkaAichler
Copy link
Collaborator

left a comment

Great work Ilkin and Elena!!!!

@ilkinabdullayev ilkinabdullayev merged commit c761310 into master May 30, 2019

2 of 3 checks passed

continuous-integration/jenkins/pr-merge This commit is being built
Details
DCO DCO
Details
WIP Ready for review
Details

@delete-merged-branch delete-merged-branch bot deleted the remove-credential-eureka branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.