Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue API Catalog cannot be loaded under zLux #312 #314

Merged
merged 5 commits into from May 31, 2019

Conversation

@jandadav
Copy link
Collaborator

commented May 30, 2019

fix for issue API Catalog cannot be loaded under zLux #312
our configuration of spring security http headers was faulty

Another change to the apiml-auth plugin for zlux to expect HTTP RC 204 from login instead of 200

@jandadav jandadav changed the title Private/janda06/issue312 fix for issue API Catalog cannot be loaded under zLux #312 May 30, 2019

jandadav added some commits May 29, 2019

Fix spring http security headers
implementation was not correct, you can review headers settings in spring documentation

@ilkinabdullayev ilkinabdullayev force-pushed the private/janda06/issue312 branch from e03f983 to 878ef58 May 31, 2019

@codecov

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #314 into master will decrease coverage by <.01%.
The diff coverage is 30.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #314      +/-   ##
============================================
- Coverage      69.3%   69.29%   -0.01%     
  Complexity       12       12              
============================================
  Files           235      235              
  Lines          4486     4488       +2     
  Branches        567      567              
============================================
+ Hits           3109     3110       +1     
- Misses         1224     1225       +1     
  Partials        153      153
Impacted Files Coverage Δ Complexity Δ
...aas/apicatalog/security/SecurityConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...overy/config/HttpsEurekaSecurityConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...gateway/security/config/SecurityConfiguration.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../discovery/config/EurekaSecurityConfiguration.java 60% <100%> (+2.85%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c761310...a9df5ce. Read the comment docs.

@JirkaAichler
Copy link
Collaborator

left a comment

Awesome work David!!!

@cZikos

cZikos approved these changes May 31, 2019

@JirkaAichler JirkaAichler merged commit cb9bacb into master May 31, 2019

4 of 5 checks passed

codecov/patch 30.76% of diff hit (target 60%)
Details
DCO DCO
Details
WIP Ready for review
Details
codecov/project 69.29% (target 55%)
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@delete-merged-branch delete-merged-branch bot deleted the private/janda06/issue312 branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.