Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of Discovery Service (our code) #407

Merged
merged 28 commits into from Oct 18, 2019

Conversation

@jandadav
Copy link
Contributor

jandadav commented Oct 11, 2019

Draft PR
ready for techinfo review

@jandadav jandadav changed the title WIP Cleanup of Discovery Service (our code) Cleanup of Discovery Service (our code) Oct 11, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.16%.
The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #407      +/-   ##
============================================
+ Coverage     70.77%   70.93%   +0.16%     
  Complexity       12       12              
============================================
  Files           241      243       +2     
  Lines          4400     4408       +8     
  Branches        533      537       +4     
============================================
+ Hits           3114     3127      +13     
+ Misses         1156     1152       -4     
+ Partials        130      129       -1
Impacted Files Coverage Δ Complexity Δ
...s/gateway/error/check/SecurityTokenErrorCheck.java 77.77% <ø> (-2.23%) 0 <0> (ø)
...as/gateway/filters/post/PageRedirectionFilter.java 87.5% <ø> (-0.22%) 0 <0> (ø)
...gateway/security/config/SecurityConfiguration.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../java/com/ca/mfaas/gateway/GatewayApplication.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...urity/login/dummy/DummyAuthenticationProvider.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...y/common/handler/BasicAuthUnauthorizedHandler.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...talog/controllers/api/CatalogApiDocController.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...m/ca/mfaas/gateway/security/query/QueryFilter.java 68.75% <ø> (-1.84%) 0 <0> (ø)
...as/client/DiscoverableClientSampleApplication.java 33.33% <ø> (ø) 0 <0> (ø) ⬇️
...atalog/services/status/APIDocRetrievalService.java 94.54% <ø> (-0.1%) 0 <0> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c3a2c6...5097f9e. Read the comment docs.

Copy link
Contributor

IgorCATech left a comment

Please, address the comments, and it's good to go!

@JirkaAichler

This comment has been minimized.

Copy link
Collaborator

JirkaAichler commented Oct 11, 2019

Please, try to group messages into some logical sets. Example: ZWEAD001 - ZWEAD099 web messages

@jandadav

This comment has been minimized.

Copy link
Contributor Author

jandadav commented Oct 11, 2019

Please, try to group messages into some logical sets. Example: ZWEAD001 - ZWEAD099 web messages

Do you have suggestion for the sets?

jandadav and others added 17 commits Oct 11, 2019
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
add to existing log message
fix typos
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: Vsevolod Khanin <vsevolod.khanin@broadcom.com>
Signed-off-by: Vsevolod Khanin <vsevolod.khanin@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Copy link
Contributor

ilkinabdullayev left a comment

Have a clean logs!

Copy link
Collaborator

arxioly left a comment

Great work!

@jandadav jandadav merged commit 4e308da into master Oct 18, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/patch 72.72% of diff hit (target 80%)
Details
DCO DCO
Details
WIP Ready for review
Details
codecov/project 70.93% (target 70%)
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@delete-merged-branch delete-merged-branch bot deleted the us/cleanup_discovery_our_code branch Oct 18, 2019
taban03 added a commit that referenced this pull request Nov 21, 2019
Cleanup of discovery service logs originating from Apiml code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.