New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of Discovery Service (our code) #407

Merged

jandadav merged 28 commits into master from us/cleanup_discovery_our_code

Oct 18, 2019

Contributor

jandadav commented Oct 11, 2019

Draft PR
ready for techinfo review

jandadav changed the title ~~WIP Cleanup of Discovery Service (our code)~~ Cleanup of Discovery Service (our code)

zowe-robot added under CA testing passed CA tests and removed under CA testing labels

codecov bot commented Oct 11, 2019 •

edited

Codecov Report

Merging #407 into master will increase coverage by 0.16%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master     #407      +/-   ##
============================================
+ Coverage     70.77%   70.93%   +0.16%     
  Complexity       12       12              
============================================
  Files           241      243       +2     
  Lines          4400     4408       +8     
  Branches        533      537       +4     
============================================
+ Hits           3114     3127      +13     
+ Misses         1156     1152       -4     
+ Partials        130      129       -1

Impacted Files	Coverage Δ	Complexity Δ
...s/gateway/error/check/SecurityTokenErrorCheck.java	`77.77% <ø> (-2.23%)`	`0 <0> (ø)`
...as/gateway/filters/post/PageRedirectionFilter.java	`87.5% <ø> (-0.22%)`	`0 <0> (ø)`
...gateway/security/config/SecurityConfiguration.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
.../java/com/ca/mfaas/gateway/GatewayApplication.java	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...urity/login/dummy/DummyAuthenticationProvider.java	`100% <ø> (ø)`	`0 <0> (ø)`	⬇️
...y/common/handler/BasicAuthUnauthorizedHandler.java	`100% <ø> (ø)`	`0 <0> (ø)`	⬇️
...talog/controllers/api/CatalogApiDocController.java	`100% <ø> (ø)`	`0 <0> (ø)`	⬇️
...m/ca/mfaas/gateway/security/query/QueryFilter.java	`68.75% <ø> (-1.84%)`	`0 <0> (ø)`
...as/client/DiscoverableClientSampleApplication.java	`33.33% <ø> (ø)`	`0 <0> (ø)`	⬇️
...atalog/services/status/APIDocRetrievalService.java	`94.54% <ø> (-0.1%)`	`0 <0> (ø)`
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c3a2c6...5097f9e. Read the comment docs.

IgorCATech reviewed

...ommon/src/main/java/com/ca/mfaas/product/logging/LogLevelInfoFilter.java Outdated Show resolved Hide resolved

zowe-robot added ready for CA testing under CA testing and removed ready for CA testing passed CA tests labels

IgorCATech reviewed

discovery-service/src/main/resources/discovery-service-log-messages.yml Outdated Show resolved Hide resolved

IgorCATech reviewed

discovery-service/src/main/resources/discovery-service-log-messages.yml Show resolved Hide resolved

IgorCATech reviewed

Contributor

IgorCATech left a comment

Please, address the comments, and it's good to go!

zowe-robot added passed CA tests and removed under CA testing labels

Collaborator

JirkaAichler commented Oct 11, 2019

Please, try to group messages into some logical sets. Example: ZWEAD001 - ZWEAD099 web messages

jandadav dismissed IgorCATech’s stale review via 3b0add0

zowe-robot added ready for CA testing under CA testing and removed ready for CA testing passed CA tests labels

arxioly reviewed

...ommon/src/main/java/com/ca/mfaas/product/logging/LogLevelInfoFilter.java Outdated Show resolved Hide resolved

zowe-robot added passed CA tests and removed under CA testing labels

arxioly reviewed

...ommon/src/main/java/com/ca/mfaas/product/logging/LogLevelInfoFilter.java Outdated Show resolved Hide resolved

Contributor Author

jandadav commented Oct 11, 2019

Please, try to group messages into some logical sets. Example: ZWEAD001 - ZWEAD099 web messages

Do you have suggestion for the sets?

arxioly reviewed

apiml-common/src/main/java/com/ca/mfaas/product/web/HttpConfig.java Outdated Show resolved Hide resolved

arxioly reviewed

apiml-common/src/main/java/com/ca/mfaas/product/web/HttpConfig.java Show resolved Hide resolved

zowe-robot added ready for CA testing under CA testing labels

jandadav and others added 17 commits


        aligned message code and keys

81c6080

Signed-off-by: janda06 <david.janda@broadcom.com>


        Service startup message

bc6c160

Signed-off-by: janda06 <david.janda@broadcom.com>


        Code review edits

c243070

Signed-off-by: janda06 <david.janda@broadcom.com>


        add few more log messages

ab94006

add to existing log message
fix typos


        aligned keys case

a144ad4

Signed-off-by: janda06 <david.janda@broadcom.com>


        cleaned logLevelInfoFilter

eb61fe7

Signed-off-by: janda06 <david.janda@broadcom.com>


        key to module alignment

118f303

Signed-off-by: janda06 <david.janda@broadcom.com>


        removed duplicate message for HTTP

fc81afd

Signed-off-by: janda06 <david.janda@broadcom.com>


        moved service started message

c64db33

Signed-off-by: janda06 <david.janda@broadcom.com>


        removed obsolete import

fe654c8

Signed-off-by: janda06 <david.janda@broadcom.com>


        message categories and renumbering

96aa44d

Signed-off-by: janda06 <david.janda@broadcom.com>


        numbers adjusting

43ba68f

Signed-off-by: Vsevolod Khanin <vsevolod.khanin@broadcom.com>


        redundant slf4j logger removed

29076d7

Signed-off-by: Vsevolod Khanin <vsevolod.khanin@broadcom.com>


        aligned the yaml message ranges

b586041

Signed-off-by: janda06 <david.janda@broadcom.com>


        missing dir i/o error

e53ac42

Signed-off-by: janda06 <david.janda@broadcom.com>


        syntax error

b723224


        Fixes from Review

5097f9e

Signed-off-by: janda06 <david.janda@broadcom.com>

jandadav force-pushed the us/cleanup_discovery_our_code branch from f7c7593 to 5097f9e

zowe-robot added ready for CA testing under CA testing passed CA tests and removed ready for CA testing passed CA tests under CA testing labels

ilkinabdullayev approved these changes

Contributor

ilkinabdullayev left a comment

Have a clean logs!

arxioly approved these changes

Collaborator

arxioly left a comment

Great work!

jandadav merged commit 4e308da into master

4 of 5 checks passed

4 of 5 checks passed

codecov/patch 72.72% of diff hit (target 80%)

Details

DCO DCO

Details

WIP Ready for review

Details

codecov/project 70.93% (target 70%)

Details

continuous-integration/jenkins/pr-merge This commit looks good

Details

delete-merged-branch bot deleted the us/cleanup_discovery_our_code branch

taban03 added a commit that referenced this pull request


        Cleanup of Discovery Service (our code) (#407)

1e52cef

Cleanup of discovery service logs originating from Apiml code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.