Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External option to activate DEBUG mode for APIML #410

Merged
merged 4 commits into from Oct 21, 2019

Conversation

@vsev0lod
Copy link
Collaborator

vsev0lod commented Oct 18, 2019

No description provided.

@jandadav jandadav self-requested a review Oct 21, 2019
@vsev0lod vsev0lod requested a review from cZikos Oct 21, 2019
Copy link
Contributor

jandadav left a comment

Thanks Seva!

vsev0lod added 4 commits Oct 1, 2019
Signed-off-by: Vsevolod Khanin <vsevolod.khanin@broadcom.com>
Signed-off-by: Vsevolod Khanin <vsevolod.khanin@broadcom.com>
Signed-off-by: Vsevolod Khanin <vsevolod.khanin@broadcom.com>
Signed-off-by: Vsevolod Khanin <vsevolod.khanin@broadcom.com>
@vsev0lod vsev0lod force-pushed the private/khavs01/log_option branch from 0247831 to d30d8e6 Oct 21, 2019
@vsev0lod vsev0lod requested a review from jandadav Oct 21, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #410 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #410      +/-   ##
============================================
- Coverage     71.05%   71.01%   -0.05%     
  Complexity       12       12              
============================================
  Files           244      244              
  Lines          4433     4433              
  Branches        541      541              
============================================
- Hits           3150     3148       -2     
  Misses         1154     1154              
- Partials        129      131       +2
Impacted Files Coverage Δ Complexity Δ
...mfaas/product/logging/ApimlDependencyLogHider.java 85.71% <0%> (-14.29%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f3c00...d30d8e6. Read the comment docs.

Copy link
Collaborator

arxioly left a comment

Good job!

@vsev0lod vsev0lod merged commit 1ea570e into master Oct 21, 2019
5 checks passed
5 checks passed
DCO DCO
Details
WIP Ready for review
Details
codecov/patch Coverage not affected when comparing f0f3c00...d30d8e6
Details
codecov/project 71.01% (target 70%)
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@delete-merged-branch delete-merged-branch bot deleted the private/khavs01/log_option branch Oct 21, 2019
taban03 added a commit that referenced this pull request Nov 21, 2019
* external option to control log level

Signed-off-by: Vsevolod Khanin <vsevolod.khanin@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.