Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Gateway - our code #417

Merged
merged 27 commits into from Nov 4, 2019

Conversation

@taban03
Copy link
Contributor

taban03 commented Oct 24, 2019

Clean up of Gateway log messages coming from our code.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #417 into master will decrease coverage by 0.06%.
The diff coverage is 63.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #417      +/-   ##
============================================
- Coverage     70.96%   70.89%   -0.07%     
  Complexity       12       12              
============================================
  Files           246      246              
  Lines          4688     4457     -231     
  Branches        607      545      -62     
============================================
- Hits           3327     3160     -167     
+ Misses         1227     1166      -61     
+ Partials        134      131       -3
Impacted Files Coverage Δ Complexity Δ
...m/ca/mfaas/product/logging/LogLevelInfoFilter.java 92.3% <ø> (-0.55%) 0 <0> (ø)
...y/common/error/ResourceAccessExceptionHandler.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...ml/security/common/error/AuthExceptionHandler.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...as/product/gateway/GatewayInstanceInitializer.java 72% <0%> (ø) 0 <0> (ø) ⬇️
...as/gateway/config/MessageServiceConfiguration.java 0% <0%> (ø) 0 <0> (?)
...om/ca/mfaas/gateway/ws/WebSocketRoutedSession.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...om/ca/mfaas/gateway/routing/ApimlRouteLocator.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../mfaas/gateway/ws/WebSocketProxyServerHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...teway/security/config/AuthProviderInitializer.java 95.45% <100%> (-0.2%) 0 <0> (ø)
...c/main/java/com/ca/mfaas/message/core/Message.java 100% <100%> (ø) 0 <0> (ø) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f88213...b72912a. Read the comment docs.

taban03 and others added 11 commits Oct 30, 2019
Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
…ogger class

Signed-off-by: at670475 <andrea.tabone@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Fixed ServiceDefinitionProcessor messaging
minor tweaks

Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
ws logs in debug only

Signed-off-by: janda06 <david.janda@broadcom.com>
removed unused ws messages

Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
Removed docgen binary

Signed-off-by: janda06 <david.janda@broadcom.com>
Signed-off-by: janda06 <david.janda@broadcom.com>
@jandadav jandadav force-pushed the private/gateway_cleanup_our_code branch from af0c789 to 3107fe3 Nov 1, 2019
@cZikos cZikos self-requested a review Nov 1, 2019
@cZikos cZikos self-requested a review Nov 4, 2019
@ilkinabdullayev ilkinabdullayev dismissed stale reviews from plavjanik and arxioly Nov 4, 2019

Applied changes

Copy link
Contributor

ilkinabdullayev left a comment

Thanks

@cZikos
cZikos approved these changes Nov 4, 2019
@ilkinabdullayev ilkinabdullayev merged commit dd1a6a5 into master Nov 4, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/patch 63.95% of diff hit (target 80%)
Details
DCO DCO
Details
WIP Ready for review
Details
codecov/project 70.89% (target 70%)
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@delete-merged-branch delete-merged-branch bot deleted the private/gateway_cleanup_our_code branch Nov 4, 2019
taban03 added a commit that referenced this pull request Nov 21, 2019
Clean up Gateway - our code 🔊
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.