Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in startup script in gateway #427

Merged
merged 2 commits into from Nov 1, 2019

Conversation

@VitekVlcek-Broadcom
Copy link
Contributor

VitekVlcek-Broadcom commented Oct 31, 2019

    -Denvironment.hostname=${ZOWE_EXPLORER_HOST} \
    -Denvironment.ipAddress=${ZOWE_IP_ADDRESS} \

should have apiml.service prefix instead of environment
Signed-off-by: Vitek Vlcek vitezslavvit.vlcek@broadcom.com

Signed-off-by: Vitek Vlcek <vitezslavvit.vlcek@broadcom.com>
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #427 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #427      +/-   ##
============================================
- Coverage     71.08%   71.03%   -0.05%     
  Complexity       12       12              
============================================
  Files           244      244              
  Lines          4433     4433              
  Branches        541      541              
============================================
- Hits           3151     3149       -2     
  Misses         1153     1153              
- Partials        129      131       +2
Impacted Files Coverage Δ Complexity Δ
...mfaas/product/logging/ApimlDependencyLogHider.java 85.71% <0%> (-14.29%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8e230...0d6ac4e. Read the comment docs.

Copy link
Collaborator

JirkaAichler left a comment

Thanks, Vitek!

Copy link
Contributor

ilkinabdullayev left a comment

Thanks Vitek!

@JirkaAichler JirkaAichler merged commit 4f88213 into master Nov 1, 2019
3 checks passed
3 checks passed
DCO DCO
Details
WIP Ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@delete-merged-branch delete-merged-branch bot deleted the type-in-start branch Nov 1, 2019
taban03 added a commit that referenced this pull request Nov 21, 2019
Typo in the Zowe startup script for Gateway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.