Skip to content

Conversation

@cZikos
Copy link
Member

@cZikos cZikos commented Jan 31, 2020

Rework logs and ui messages for encoded characters

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #487 into master will decrease coverage by <.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #487      +/-   ##
============================================
- Coverage     73.75%   73.74%   -0.01%     
  Complexity       21       21              
============================================
  Files           288      288              
  Lines          5562     5572      +10     
  Branches        668      668              
============================================
+ Hits           4102     4109       +7     
- Misses         1290     1293       +3     
  Partials        170      170
Impacted Files Coverage Δ Complexity Δ
...zowe/apiml/gateway/routing/ApimlRoutingConfig.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...l/gateway/filters/pre/EncodedCharactersFilter.java 91.89% <76.92%> (-8.11%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d9f78...2869efe. Read the comment docs.

cZikos added 3 commits February 3, 2020 16:52
Signed-off-by: cZikos <christos.zikos@broadcom.com>
Signed-off-by: cZikos <christos.zikos@broadcom.com>
Signed-off-by: cZikos <christos.zikos@broadcom.com>
@cZikos cZikos changed the title Private/zikch01/change encoded char error msg Change error message for encodedCharacterFilter Feb 3, 2020
Signed-off-by: cZikos <christos.zikos@broadcom.com>
@cZikos cZikos force-pushed the private/zikch01/change_encoded_char_error_msg branch from 208781e to bc6758e Compare February 3, 2020 16:29
Signed-off-by: cZikos <christos.zikos@broadcom.com>
Copy link
Contributor

@ilkinabdullayev ilkinabdullayev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@taban03 taban03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants