Skip to content

Conversation

@pavel-jares-bcm
Copy link
Contributor

When service is registration into discovery service, discovery service notify about change all gateways. They can evict caches and speed up registry update.

This PR fix this process:

  • do not notify gateway itself about its registration
  • if any gateway is not available, dont distribute exception from REST (it can break whole process)
  • instanceof trackstack write only message into log

…egistration process

Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@aad1382). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #525   +/-   ##
=========================================
  Coverage          ?   74.11%           
=========================================
  Files             ?      299           
  Lines             ?     5649           
  Branches          ?      675           
=========================================
  Hits              ?     4187           
  Misses            ?     1293           
  Partials          ?      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad1382...209ed5b. Read the comment docs.

JirkaAichler and others added 2 commits February 26, 2020 16:45
Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@JirkaAichler JirkaAichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@JirkaAichler JirkaAichler merged commit 5c5f2ab into master Feb 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the protectors/gwNotificationFix branch February 26, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants