Check that the ignoring SslContextFactory has empty keystore #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
JirkaAichler
reviewed
Mar 3, 2020
common-service-core/src/main/java/org/zowe/apiml/security/HttpsFactory.java
Outdated
Show resolved
Hide resolved
common-service-core/src/main/java/org/zowe/apiml/security/HttpsFactory.java
Show resolved
Hide resolved
common-service-core/src/test/java/org/zowe/apiml/security/HttpsFactoryTest.java
Show resolved
Hide resolved
Signed-off-by: Petr Plavjanik <plavjanik@gmail.com>
pavel-jares-bcm
approved these changes
Mar 4, 2020
|
SonarCloud Quality Gate failed.
|
|
The PR has added new unit tests and has not affected z/OS integration tests. Integration tests were run manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A unit test that checks that ignoringSslContextFactory has empty keystore (necessary for IBM Java to not use the javax.net properties to load the keystore) to make sure that code in #527
will work in the future.
I could not find public API to get the keystore and the reflection did not work for me either so adding a package field was the easiest option.
Signed-off-by: Petr Plavjanik plavjanik@gmail.com