Skip to content

Conversation

@pavel-jares-bcm
Copy link
Contributor

Integration test LogoutTest is testing integration of REST API to z/OSMF. For this reason it is not possible to test it on localhost without dependecies and it is mark to run just on mainframe

Signed-off-by: Pavel Jareš pavel.jares@broadcom.com

…host

Signed-off-by: Pavel Jareš <pavel.jares@broadcom.com>
Copy link
Member

@balhar-jakub balhar-jakub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have discussed and as the Logout now requires the ZOSM/f to work for the time being this is going to be Mainframe only test.

At some point we need to discuss the possibility to Mock the key parts of ZOSM/f for local integration tests

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4bc6df3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #551   +/-   ##
=========================================
  Coverage          ?   77.79%           
=========================================
  Files             ?      308           
  Lines             ?     5864           
  Branches          ?      710           
=========================================
  Hits              ?     4562           
  Misses            ?     1118           
  Partials          ?      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc6df3...22ad3f6. Read the comment docs.

@pavel-jares-bcm pavel-jares-bcm merged commit 68ee46f into master Mar 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the protectors/logoutTestJustOnMainframe branch March 11, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants