Skip to content

Conversation

@CarsonCook
Copy link
Contributor

Signed-off-by: Carson Cook carson.cook@ibm.com

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • If the changes in this PR is part of the next future release, make this pull request against the docs-staging branch which will be published at the next release boundary. If the changes in this PR are part of the current release, use the default base branch, master. For more information about branches, see https://github.com/zowe/docs-site/tree/master#understanding-the-doc-branches.

  • If this PR relates to GitHub issues in docs-site or other repositories, please list in Description, prefixed with close, fix or resolve keywords.

Description (including links to related git issues)

Resolve api-layer #744. Malformed relative administrative URLs (such as homePageRelativeUrl) can occur when they don't begin with / and/or baseUrl ends with a trailing /. This PR adds a note in the description of the baseUrl parameter. The note mentions warning logs, which is implemented in api-layer PR #775.

Signed-off-by: Carson Cook <carson.cook@ibm.com>
Signed-off-by: BrandonJenkins14 <36675406+BrandonJenkins14@users.noreply.github.com>
Copy link
Contributor

@BrandonJenkins14 BrandonJenkins14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a slight change to wording and bolded Note:. Thanks for the contribution!

@BrandonJenkins14 BrandonJenkins14 merged commit 5f5788e into docs-staging Aug 12, 2020
@BrandonJenkins14 BrandonJenkins14 deleted the carsoncook/gh744/urlSlashFormatting branch August 12, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants