Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter JES based on App2App communication #92

Merged

Conversation

@1000TurquoisePogs
Copy link
Member

commented May 22, 2019

Adding prototype of app2app communication listening subject to change in structure with app2app improvements for iframes

Q: How does this work?
A: iframes can now be sent messages through zowe/zlux-app-manager#107 and zowe/zlux-platform#24 ... so it's just up to the iframe apps to listen & react however the developer wants.

The prototype structure is currently
event.data.dispatchType determines which type of message, and event.data.dispatchData contains a structure dependent upon the type. Maybe dispatchData doesn't exist for certain types yet to be implemented.

I believe this should be completely harmless for the as-is case that nothing is actually sending messages to the explorer, so putting this PR out for future use.

Thanks to @jordanCain for helping guide to the right file to place this code & test stuff out.

Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com

jackjia-ibm and others added 4 commits May 14, 2019
Merge branch 'staging'
Signed-off-by:  <>
0.0.20
Signed-off-by: zowe-robot <zowe.robot@gmail.com>
add jcain as admin
Signed-off-by: Jack (T.) Jia <jack-tiefeng.jia@ibm.com>
Adding prototype of app2app communication listening subject to change…
… in structure with app2app improvements for iframes

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Changing strange linting issues
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
More linting issues
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Adding mock for window add event listener
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Linting things?
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Allow for app2app to function right on startup
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>

@jordanCain jordanCain changed the base branch from master to staging Jun 10, 2019

@jordanCain jordanCain merged commit 598df71 into zowe:staging Jun 10, 2019

2 checks passed

DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.