New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVS explorer editor can not be displayed becuase of "TypeError: Cannot read property 'setContents' of null" #5

Closed
LiangXuehongBJ opened this Issue Sep 14, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@LiangXuehongBJ

LiangXuehongBJ commented Sep 14, 2018

[
screen shot 2018-09-13 at 3 19 59 pm
screen shot 2018-09-13 at 3 21 18 pm
screen shot 2018-09-13 at 3 21 30 pm

MVS explorer editor could not show content because of an exception often.

Sometimes it works fine, sometimes it does not.

It can be reproduced easily with zowe 0.8.3 or 0.9.0.

Could you please help to take a look at this issue?

Thank you very much!

@jordanCain

This comment has been minimized.

Contributor

jordanCain commented Sep 26, 2018

This is likely due to a race condition where we try to set the content of the editor before the editor has been initialised. I'll take a look into adding logic to prevent the requesting of content until after the editor has been initialised.

@LiangXuehongBJ

This comment has been minimized.

LiangXuehongBJ commented Oct 23, 2018

Hi, Jordan.
Will this issue be fixed in Zowe 0.9.3 release?
Thank you very much!

@jordanCain

This comment has been minimized.

Contributor

jordanCain commented Oct 23, 2018

@LiangXuehongBJ A fix for this went in, #13 just awaiting validation

@jordanCain

This comment has been minimized.

Contributor

jordanCain commented Oct 29, 2018

@LiangXuehongBJ Im no longer able to reproduce this in 0.9.2 therefore I will mark this issue as closed. If you are able to reproduce this feel free to re open this issue

@jordanCain jordanCain closed this Oct 29, 2018

@LiangXuehongBJ

This comment has been minimized.

LiangXuehongBJ commented Nov 6, 2018

@jordanCain I can reproduce this issue in 0.9.2 now.

Here are logs in console.log:
VM806 app.min.js:1025 action RECEIVE_CONTENT @ 10:11:05.183
VM809 app.min.js:1025 action REQUEST_CONTENT @ 10:11:05.874
VM809 app.min.js:1025 action RECEIVE_CONTENT @ 10:11:06.158
app.min.js:1025 action REQUEST_CONTENT @ 10:12:32.524
app.min.js:1025 action RECEIVE_CONTENT @ 10:12:32.840
app.min.js:1025 action PUSH_NOTIFICATION_MESSAGE @ 10:12:32.853
app.min.js:1025 action INVALIDATE_CONTENT @ 10:12:32.860
app.min.js:1025 action POP_NOTIFICATION_MESSAGE @ 10:12:36.858

@LiangXuehongBJ

This comment has been minimized.

LiangXuehongBJ commented Nov 6, 2018

screen shot 2018-11-06 at 10 48 10 am

@jordanCain jordanCain reopened this Nov 14, 2018

@jordanCain

This comment has been minimized.

Contributor

jordanCain commented Nov 14, 2018

New fix in #29

@jordanCain

This comment has been minimized.

Contributor

jordanCain commented Nov 21, 2018

fix #29 has been validated and therefore this issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment