Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App2App PostMessage callback for iframes #107

Merged

Conversation

@1000TurquoisePogs
Copy link
Contributor

commented May 22, 2019

  • Cleanup to work for sample-iframe-app
  • Bugfix to not just throw exceptions when the platform periodically echos to iframes (for testing purposes...)
  • New functionality to attempt handling of double-iframe case seen in explorers & jupyter app... In order for this to work reliably, a reserved name is needed. Seems we're gravitating towards "zluxIframe" at this time, so we should cement that.

Other changes:

  • Corejs recommended an update, I see no issues there
  • html2canvas too, but also found out how to turn off its aggressive logging

REQUIRES zowe/zlux-platform#24

1000TurquoisePogs added some commits May 15, 2019

WIP on adding iframe app2app. Updated html2canvas and removed its exc…
…essive logging.

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Add case for double iframe, but needs reserved name
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>

1000TurquoisePogs added some commits May 23, 2019

Cleanup of special string and comment
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Added missing header
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>

@1000TurquoisePogs 1000TurquoisePogs merged commit 931074f into zowe:staging May 23, 2019

2 checks passed

DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.