Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multi-window indicator bug #123

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@sakeerthy
Copy link

commented Jul 5, 2019

The reason the issue was happening only on the unpinned plugins was that the pinned plugins would be refreshed every time there was a new login, all the plugins were only refreshed once the launch bar was initialized. I changed it so all the plugins would be refreshed every time there is a new login which fixes the bug described: https://jira.rocketsoftware.com/browse/MVD-2787

Suneeth Keerthy
Fixed multi-window indicator bug
Signed-off-by: Suneeth Keerthy <skeerthy@rocketsoftware.com>
@1000TurquoisePogs
Copy link
Contributor

left a comment

Tested this way:
open pinned app 3 times: 3 dots
logout
open pinned app once more: 1 dot
open unpinned app 3 times: 3 dots
logout
open unpinned app once more: was 4 dots before, now is 1 dot.

I have some slight concern with if this is performant, due to array manipulation, but didn't notice sluggish performance due to more logic in ngDoCheck, so this seems OK.

@1000TurquoisePogs 1000TurquoisePogs merged commit 22e00c0 into zowe:staging Jul 11, 2019

2 checks passed

DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.