Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set desktop title dynamically to focused app #175

Merged
merged 3 commits into from Nov 6, 2019

Conversation

@NakulManchanda
Copy link
Contributor

NakulManchanda commented Oct 29, 2019

Signed-off-by: Nakul Manchanda nakul.manchanda@ibm.com

Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
@NakulManchanda

This comment has been minimized.

Copy link
Contributor Author

NakulManchanda commented Oct 30, 2019

done as part of issue - zowe/zlux#242

Copy link

DivergentEuropeans left a comment

This works good from my small round of testing. Plays nicely with the Editor file name title changing as well
image

image

There's such little horizontal space for the tab names. Maybe we should shorten to "Zowe | etc etc"? @NakulManchanda @1000TurquoisePogs

Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
@NakulManchanda

This comment has been minimized.

Copy link
Contributor Author

NakulManchanda commented Nov 6, 2019

hi, @DivergentEuropeans , @1000TurquoisePogs - can we have this in 1.7.0, i can add new item to have default title and title format configurable.
These changes seems to work well, let me know if there is any feedback.

This change will make title of Desktop Dynamic

  • No Apps - Zowe Desktop
  • App open and Focused - Zowe | Focused App Title
@jplinardon jplinardon requested a review from 1000TurquoisePogs Nov 6, 2019
Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
@NakulManchanda NakulManchanda force-pushed the NakulManchanda:set-desktop-title branch from 7f56d03 to feebdad Nov 6, 2019
Copy link

DivergentEuropeans left a comment

Changes addressed, looks good

@1000TurquoisePogs 1000TurquoisePogs merged commit 0fed13b into zowe:staging Nov 6, 2019
2 checks passed
2 checks passed
DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.