New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ipAddresses field for zlux and agent(zss) for specifying binding to specific IPs #30

Merged
merged 3 commits into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@1000TurquoisePogs
Copy link
Contributor

1000TurquoisePogs commented Dec 12, 2018

To better structure this config file, I'm putting the IP address specification that would be used for ZSS within an "agent" body, where I'd like zssPort to eventually be moved as http.port, or https.port.
Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com

Adding ipAddresses field for zlux and agent(zss) for specifying bindi…
…ng to specific IPs

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>

@1000TurquoisePogs 1000TurquoisePogs requested a review from zowe/committers-zlux-example-server Dec 12, 2018

@wafflebot wafflebot bot added the review label Dec 12, 2018

Using ipAddresses within each connection type, rather than as a whole
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
@reetchow
Copy link
Contributor

reetchow left a comment

I built this and it ran on my environment

@1000TurquoisePogs 1000TurquoisePogs merged commit cd0ec64 into zowe:master Jan 14, 2019

@wafflebot wafflebot bot removed the review label Jan 14, 2019

@1000TurquoisePogs 1000TurquoisePogs added this to the 19-01-22 - 1.0.0 milestone Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment