Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration improvements part 1 #81

Merged
merged 9 commits into from Nov 6, 2019

Conversation

@1000TurquoisePogs
Copy link
Member

1000TurquoisePogs commented Oct 21, 2019

Change to enable D args, more options available from JSON, and some cleanup

Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com

…leanup

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
@1000TurquoisePogs 1000TurquoisePogs requested a review from zowe/committers-app-server-framework Oct 21, 2019
@@ -6,6 +6,15 @@
# SPDX-License-Identifier: EPL-2.0
#
# Copyright Contributors to the Zowe Project.
dir="$(dirname $(readlink -f $0))"

This comment has been minimized.

Copy link
@1000TurquoisePogs

1000TurquoisePogs Oct 21, 2019

Author Member

Cant use readlink on z/os as far as i know. may be a bash command.

@@ -6,6 +6,15 @@
# SPDX-License-Identifier: EPL-2.0
#
# Copyright Contributors to the Zowe Project.
dir="$(dirname $(readlink -f $0))"

This comment has been minimized.

Copy link
@1000TurquoisePogs

1000TurquoisePogs Oct 21, 2019

Author Member

Same here

@@ -12,7 +12,8 @@
"server": {
"hostname": "localhost",
"port": 10011,
"isHttps": false
"gatewayPort": 10012,

This comment has been minimized.

Copy link
@1000TurquoisePogs

1000TurquoisePogs Oct 21, 2019

Author Member

spacing???

@@ -23,18 +24,8 @@
}
]
},
"agent": {

This comment has been minimized.

Copy link
@1000TurquoisePogs

1000TurquoisePogs Oct 21, 2019

Author Member

Comment it out instead of removing it?

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Copy link

DivergentEuropeans left a comment

Multiple many changes addressed : )

@1000TurquoisePogs 1000TurquoisePogs merged commit 12e0841 into staging Nov 6, 2019
2 checks passed
2 checks passed
DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@1000TurquoisePogs 1000TurquoisePogs deleted the feature/config-and-arg-changes branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.