Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set suppressScrollY to true for perfect scroll file tabs component #55

Merged
merged 1 commit into from Jun 20, 2019

Conversation

@jordanCain
Copy link
Contributor

commented Jun 11, 2019

Fix editor file tab behaviour that allows for undesired vertical scrolling

Signed-off-by: Jordan Cain jordan.cain1@uk.ibm.com

supressYScrolling of file tab to true for bug fix
Signed-off-by: Jordan Cain <jordan.cain1@uk.ibm.com>
@jordanCain

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

resolves zowe/zlux#170

@jordanCain jordanCain closed this Jun 13, 2019

@jordanCain jordanCain deleted the jordanCain:fix-tab-scrolling branch Jun 13, 2019

@jordanCain jordanCain restored the jordanCain:fix-tab-scrolling branch Jun 13, 2019

@jordanCain jordanCain reopened this Jun 13, 2019

@DivergentEuropeans

This comment has been minimized.

Copy link

commented Jun 13, 2019

Hey @jordanCain Most of the main Zowe guys, including myself, have been busy this week with a Rocket Build (hackathon type) event. That's why things have had a slight pause. I, or someone else, will get back to you soon and test this. It's 1 line, seems simple enough ( :

@DivergentEuropeans
Copy link

left a comment

This works, tested with Edge, FF, Chrome, Safari.

Unfortunately, we still have a moderately buggy UI when there's too many tabs. Horizontal scroll works (which is good, a similar thing to VSCode) but otherwise has questionable scrollbar visibility & white missing textured areas.
image

I approve @1000TurquoisePogs

@1000TurquoisePogs 1000TurquoisePogs merged commit 61d1dc3 into zowe:staging Jun 20, 2019

2 checks passed

DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.