Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for file tab display issues in Chrome #60

Merged
merged 4 commits into from Jun 20, 2019

Conversation

@timgerstel
Copy link

commented Jun 19, 2019

Previously in Chrome, filenames would wrap onto a new line creating an additional vertical scroll bar in the file tab display. Additionally, the filename would wrap the close button below the tab which gives the appearance of a missing close button. Both issues have been mitigated by wrapping the filename within a span and setting a maximum width for the text. To ensure the scroll bar does not reappear, the bottom margin in the tabs-file-list class has been set to 0px.

2019_01_11_11_53_48_Zowe_Desktop_File_interface

Fixed

Opening many tabs past the current width of the window also created an additional horizontal scroll bar for the body of the app. This issue has been mitigated by setting a width for the gz-editor class.

Timothy Gerstel added some commits Jun 19, 2019

Timothy Gerstel
File names are now wrapped within a span to manage overflow. Close bu…
…tton is no longer hidden and extraneous margins have been removed

Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>
Timothy Gerstel
Added width attribute gz-editor class to prevent tabs-file-list from …
…generating overflow/unexpected scrollbars

Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>
@@ -162,7 +162,7 @@
}
}
.gz-editor {
// width: 100%;
width: 600px;

This comment has been minimized.

Copy link
@1000TurquoisePogs

1000TurquoisePogs Jun 20, 2019

Contributor

Rest is OK, but this one doesn't make sense. What would happen if I had the window smaller or larger?

This comment has been minimized.

Copy link
@timgerstel

timgerstel Jun 20, 2019

Author

To be quite honest I am not sure why this fixed the issue, however its behavior is consistent between Chrome and Firefox.
Here I have expanded the window past 600px, and the fitment works perfectly even with the fixed width. It seems that setting the width to anything expect for 100% fixes the issue of the view-lines expanding past their intended container.
image

This comment has been minimized.

Copy link
@timgerstel

This comment has been minimized.

Copy link
@timgerstel

timgerstel Jun 20, 2019

Author

This is not an issue that was included as part of the ticket, but it occurs on the version of zlux-editor in the staging branch of :zowe/zlux-editor as well

Timothy Gerstel
Fixed issue where tabs would create styling issues for editor body
Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>

@1000TurquoisePogs 1000TurquoisePogs self-requested a review Jun 20, 2019

Timothy Gerstel
ngx-perfect-scrollbar for file tabs now pertains a seperate configura…
…tion which enables x axis scrolling and suppresses Y axis scrolling.

Signed-off-by: Timothy Gerstel <tgerstel@rocketsoftware.com>
@1000TurquoisePogs

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

Tested as working.

@1000TurquoisePogs 1000TurquoisePogs merged commit 4b04861 into zowe:staging Jun 20, 2019

2 checks passed

DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@timgerstel timgerstel changed the title [MVD-2438] Fix for file tab display issues in Chrome Fix for file tab display issues in Chrome Jun 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.