Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save and restore cursor and view between tabs #71

Merged

Conversation

@1000TurquoisePogs
Copy link
Contributor

commented Jul 15, 2019

Cache and restore cursor and view information per opened file upon selection change
This utilizes monaco's ability to get and set states for the cursor, selection, and view - so we're giving monaco all the info that it expects upon changing the view between multiple files.
Basically, before when selecting tabs in the editor, each tab would get the cursor reset to position 0,0 and any text would be deselected. Now, the position & selection is all preserved while the file remains open. Upon closing the file this information is purged.
Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com

Cache and restore cursor and view information per opened file upon se…
…lection change

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>

@1000TurquoisePogs 1000TurquoisePogs requested a review from Jul 15, 2019

@1000TurquoisePogs

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

The only thing I have not yet figured out is how to get the textbox to be active when this switch happens. I would expect it to, but the tab bar remains active so the text isnt highlighted right away.

@jordanfilteau1995
Copy link
Contributor

left a comment

It looks like you are just implementing some Monaco specific features here. These changes look okay syntax and concept wise based on your description. These are good changes and will help the editor usability for sure.

@jordanfilteau1995

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

I’m going to merge and get things rolling.

@jordanfilteau1995 jordanfilteau1995 merged commit d7aca00 into zowe:staging Jul 16, 2019

2 checks passed

DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.