Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to USS home directory #16

Merged
merged 3 commits into from Jul 1, 2019

Conversation

@jordanCain
Copy link
Contributor

commented Jun 17, 2019

Signed-off-by: Jordan Cain jordan.cain1@uk.ibm.com

Feature - auto load user home directory by using omvs segment api
Signed-off-by: Jordan Cain <jordan.cain1@uk.ibm.com>
@1000TurquoisePogs

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

I'm hesitant about this one due to asychronous behavior. This looks like if the network was slow & I was fast, I could begin typing a path only to have it reset to my home dir as soon as the omvs response is fulfilled.
Ideally, disabling input and adding a loading indicator would solve that.

jordanCain added some commits Jun 28, 2019

add loading indicator
Signed-off-by: Jordan Cain <jordan.cain1@uk.ibm.com>
change placeholder back to Enter a Directory...
Signed-off-by: Jordan Cain <jordan.cain1@uk.ibm.com>
@1000TurquoisePogs

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

reviewed & tested, this looks good. Thank you

@1000TurquoisePogs 1000TurquoisePogs merged commit 07bc657 into zowe:src-for-widgets Jul 1, 2019

1 check passed

DCO DCO
Details

@NolanRogers NolanRogers added this to the 1.4.0 milestone Jul 19, 2019

@jordanCain jordanCain deleted the jordanCain:default-uss-home-directory branch Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.