Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented disabled persistent dataservice #22

Conversation

@NakulManchanda
Copy link
Member

commented Jul 12, 2019

Signed-off-by: Nakul Manchanda nakul.manchanda@ibm.com

commented disabled persistent dataservice
Signed-off-by: Nakul Manchanda <nakul.manchanda@ibm.com>
@NakulManchanda

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

  1. Persistent data service was disabled by returning null, but that caused a crash on ngDestory in zlux-file-explorer.component.ts ,
  2. and due to above crash ngDestroy of project-tree.component.ts never get called, preventing unsubscribe on observers, resulting in unexpected behavior and memory leak.
@DivergentEuropeans
Copy link

left a comment

Closed Editor, all 3 ngOnDestroys I set up in various parts of the code get called, so this no longer breaks Editor's ngOnDestroy.

I approve

@1000TurquoisePogs 1000TurquoisePogs merged commit 9bda58d into zowe:src-for-widgets Jul 15, 2019

1 check passed

DCO DCO
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.