Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click delete files & folders #43

Conversation

@DivergentEuropeans
Copy link

DivergentEuropeans commented Oct 3, 2019

  • Added a delete option for files & folders in the right click menu
  • Added a popup to confirm delete
  • Added notification framework UI for delete responses

PR 1 of 2
PR 2 zowe/zlux-app-manager#165

<Signed-off-by: Leanid Astrakou lastrakou@rocketsoftware.com

Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
@DivergentEuropeans DivergentEuropeans changed the title (WIP) Intial prototype for delete modal and delete event (WIP) Initial prototype for delete modal and delete event Oct 3, 2019
Leanid Astrakou added 2 commits Oct 7, 2019
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
@DivergentEuropeans DivergentEuropeans self-assigned this Oct 7, 2019
@DivergentEuropeans DivergentEuropeans changed the title (WIP) Initial prototype for delete modal and delete event Right click delete files & folders Oct 7, 2019
import { FilePropertiesModal } from '../file-properties-modal/file-properties-modal.component';
import { DeleteFileModal } from '../delete-file-modal/delete-file-modal.component';
import { ZoweNotification } from '../../../../../../../../../zlux-platform/base/src/notification-manager/notification';

This comment has been minimized.

Copy link
@1000TurquoisePogs

1000TurquoisePogs Oct 7, 2019

Member

Not wrong but brittle, using an alias in tsconfig is better such as in here https://github.com/zowe/zlux-app-manager/blob/master/virtual-desktop/tsconfig.json#L38

This comment has been minimized.

Copy link
@DivergentEuropeans

DivergentEuropeans Oct 7, 2019

Author

Unfortunately, was not able to get this to work. Tried all sorts of working with tsconfig and no dice

Leanid Astrakou added 5 commits Oct 7, 2019
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
@1000TurquoisePogs 1000TurquoisePogs merged commit f9b7938 into zowe:staging Oct 9, 2019
1 check passed
1 check passed
DCO DCO
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.