Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype Dataset properties right click menu #49

Conversation

@DivergentEuropeans
Copy link

DivergentEuropeans commented Oct 28, 2019

  • Added a right click "Properties" menu for datasets

image

  • Additionally, I added help links to redirect to IBM pages for some less common terminology

image

Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
@DivergentEuropeans DivergentEuropeans requested review from 1000TurquoisePogs and zowe/committers-apps Oct 28, 2019
@DivergentEuropeans DivergentEuropeans self-assigned this Oct 28, 2019
Leanid Astrakou added 6 commits Oct 28, 2019
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
if (this.windowActions) {
let didContextMenuSpawn = this.windowActions.spawnContextMenu(event.originalEvent.clientX, event.originalEvent.clientY, rightClickProperties, true);
// TODO: Fix Zowe's context menu such that if it doesn't have enough space to spawn, it moves itself accordingly to spawn.
if (!didContextMenuSpawn) { // If context menu failed to spawn...

This comment has been minimized.

Copy link
@1000TurquoisePogs

1000TurquoisePogs Oct 31, 2019

Member

While we do need to fix this, this is not a guaranteed fix: what if it fails twice? May want to loop?

This comment has been minimized.

Copy link
@DivergentEuropeans

DivergentEuropeans Nov 1, 2019

Author

This may not be ideal because context menu can fail for various reasons, and a loop would just crash the app unless we put a counter. But if it doesn't show after the offset (the FE node height) it probably isn't showing for a different reason

Copy link
Member

1000TurquoisePogs left a comment

If you have an entry of type A (I guess, but its not exclusive???) that is migrated, then it will have very little info available. However, one thing you do know, is that it is migrated.
That field should be present when the others are missing.
image

@1000TurquoisePogs

This comment was marked as resolved.

Copy link
Member

1000TurquoisePogs commented Oct 31, 2019

Also other problems:
You will get N/A when...
Record format is undefined (basically, length unknown) - a PDS of U could just be "PDS", or "PDS0" ???
Record format is not exactly 80/256: a PDS of 150 could just be "PDS150"

Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou added 4 commits Nov 1, 2019
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
@1000TurquoisePogs 1000TurquoisePogs merged commit 55ab6a0 into zowe:staging Nov 4, 2019
1 check passed
1 check passed
DCO DCO
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.