Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App2App for iframes (launch & message) #24

Merged

Conversation

@1000TurquoisePogs
Copy link
Contributor

commented May 22, 2019

Solved various issues:

  • echo test was not discriminating on what was and wasnt iframe, leading to exceptions
  • postmessage needed for iframe app2app was never called for message or launch

Needed to implement:

  • iframes take time to load, and without knowledge of the iframes in the app framework, iframes need to inform the framework of when they have loaded so that any launch context can be provided only after they are ready. To do this, the info to be sent is cached until the iframe is ready.
    Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com
WIP on sending launchMetadata and message from app2app to iframe apps
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Get rid of build test error
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Cleanup based on code review
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>

@1000TurquoisePogs 1000TurquoisePogs merged commit 621ff26 into zowe:staging May 23, 2019

2 checks passed

DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.