Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI -D arguments #154

Merged
merged 12 commits into from Nov 6, 2019

Conversation

@1000TurquoisePogs
Copy link
Member

1000TurquoisePogs commented Oct 18, 2019

Allow overriding of any config attribute via java/C-like -D argument syntax.
TODOs and comments within about what this doesn't cover: not trying to make this completely faithful to JSON at this point, but just to cover strings well.
Check on: correct behavior for numbers & booleans
Needed by: zowe/zlux-app-server#80

zowe-robot and others added 8 commits Jun 13, 2019
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: Sean Grady <sgrady@rocketsoftware.com>
Signed-off-by: Sean Grady <sgrady@rocketsoftware.com>
@1000TurquoisePogs 1000TurquoisePogs requested review from stevenhorsman, dmitrynikolaev and zowe/committers-app-server-framework Oct 18, 2019
TODO: support array insertion
*/
function resolveJson(argumentsObj, matchObj) {
const matchParts = matchObj.jsonName.split('.');

This comment has been minimized.

Copy link
@1000TurquoisePogs

1000TurquoisePogs Oct 21, 2019

Author Member

Support for number & boolean???

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Bugfixes
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Copy link

DivergentEuropeans left a comment

Pioneered by X me

@1000TurquoisePogs 1000TurquoisePogs merged commit 8b821cb into staging Nov 6, 2019
2 checks passed
2 checks passed
DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@1000TurquoisePogs 1000TurquoisePogs deleted the feature/D-args branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.