Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an env-to-json function #156

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@1000TurquoisePogs
Copy link
Member

1000TurquoisePogs commented Nov 7, 2019

This allows for you to specify env vars that can be interpreted as some composite JSON-like structure.
Limitations in the code commends: This is biased towards relatively human-readable JSON attribute names, so the regex used is not flawless but simplistic and will fail fast on purpose if given bizarre input.

How to test: const parser = require('./argumentParser'); parser.envUnitTest() and read the output.

Signed-off-by: 1000TurquoisePogs sgrady@rocketsoftware.com

Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
Copy link

DivergentEuropeans left a comment

This part works for what it's supposed to do, it seems

@1000TurquoisePogs 1000TurquoisePogs merged commit de0d31b into zowe:staging Nov 8, 2019
2 checks passed
2 checks passed
DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@1000TurquoisePogs 1000TurquoisePogs deleted the 1000TurquoisePogs:feature/env-var branch Dec 2, 2019
@1000TurquoisePogs 1000TurquoisePogs restored the 1000TurquoisePogs:feature/env-var branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.