add port to cookie name to differentiate multiple servers on same domain #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Wellman <twellman@rocketsoftware.com>
ghost
assigned 
1000TurquoisePogs
requested changes
Apr 30, 2019
lib/webapp.js
Outdated
| @@ -533,6 +533,7 @@ function WebApp(options){ | |||
| this.expressApp.use(cookieParser()); | |||
| this.expressApp.use(session({ | |||
| //TODO properly generate this secret | |||
| name: 'connect.sid.' + options.httpsPort, | |||
There was a problem hiding this comment.
This is not 100%.... it's possible for someone to have enabled http and disabled https (though discouraged).
Instead, check if https ISNT being used. If it isn't, use http. If both are being used, you can still use https since you have to choose only 1.
Signed-off-by: Todd Wellman <twellman@rocketsoftware.com>
lib/webapp.js
Outdated
| let port = options.httpsPort; | ||
| if (!options.httpsPort) { | ||
| port = options.httpPort; | ||
| } |
There was a problem hiding this comment.
Better way to do this is:
const port = options.httpsPort ? options.httpsPort : options.httpPort;
Allows use of const for read-only, and also does not need reassignment.
Signed-off-by: Todd Wellman <twellman@rocketsoftware.com>
Signed-off-by: Todd Wellman <twellman@rocketsoftware.com>
1000TurquoisePogs
approved these changes
May 7, 2019
There was a problem hiding this comment.
Yup - tested in the following ways
- If I login to two servers in 1 browser, does one get logged out?
- If I do REST requests to either, is one logged out?
- If I log out of one, am I logged out of the other?
- If I did log out, do I get 401s on one but not on the other?
Behavior seems correct now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Todd Wellman twellman@rocketsoftware.com