Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "mode=base64" option to unixfile API #127

Closed
NolanRogers opened this issue Apr 10, 2019 · 1 comment

Comments

@NolanRogers
Copy link

commented Apr 10, 2019

For files that can be represented as text, having a base64 mode to the unix file API allows an additional layer of security from accidentally interpreting plaintext as HTML.

Consider the file with contents "hello world" becomes "aGVsbG8gd29ybGQ="

"zlux-editor" should take advantage of this new option when it is ready.

Acceptance Criteria:

Change existing unixfile API behavior, add a new optional "mode=raw" ... test that this is true via use of file-transfer-app

Should not consume excessive memory on either server or browser... so API should only stream, rather than read an entire file into memory

If you do not support binaries or large files, you should define cases in which the server rejects the request... HTTP 400 "File too large" for example. Files over 50 or 100MB are generally not something you want to look at, so that's a reasonable limit if you need to have one.

@1000TurquoisePogs

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

This is now in... we did responseType rather than mode. https://github.com/zowe/zlux-app-server/blob/master/doc/swagger/fileapi.yaml#L333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.