V3 Conformance + `zos-node-accessor` update #155

zFernand0 · 2024-03-04T22:28:16Z

What It Does

Address most/all breaking changes from imperative and other SDKs
Update zos-node-accessor to v2

How to Test

Build and run the plug-in 😋

Review Checklist
I certify that I have:

tested my changes
added/updated automated tests
updated the changelog
followed the contribution guidelines

Additional Comments

More changes to come 😋

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

src/api/CreateDataset.ts

-                }
+            if (tempOptions.printAttributes) {
+                delete tempOptions.printAttributes;
+                response = TextUtils.prettyJson(tempOptions);


Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

codecov-commenter · 2024-03-05T22:05:00Z

Codecov Report

Attention: Patch coverage is 83.43558% with 27 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (next@3bc2e29). Click here to learn what that means.

Files	Patch %	Lines
src/api/CreateDataset.ts	0.00%	10 Missing ⚠️
src/api/UssUtils.ts	81.25%	6 Missing ⚠️
src/api/DataSetUtils.ts	84.61%	4 Missing ⚠️
src/api/CoreUtils.ts	71.42%	2 Missing ⚠️
src/api/FTPConfig.ts	77.77%	2 Missing ⚠️
src/api/JobUtils.ts	94.59%	2 Missing ⚠️
src/api/AbstractTemplatedJCL.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             next     #155   +/-   ##
=======================================
  Coverage        ?   73.36%           
=======================================
  Files           ?       77           
  Lines           ?      976           
  Branches        ?      125           
=======================================
  Hits            ?      716           
  Misses          ?      260           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

anaxceron

Your particular changes look pretty good. The rest of the ReadMe should be edited. I left comments.

README.md

gejohnston

I left one comment that you could investigate. Worst case, leaving function getProfileMeta in the code is probably harmless.

src/api/CoreUtils.ts

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

anaxceron

great!

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

traeok

Thanks for all of your work on this!
I noticed that a couple of the unit tests are failing on Windows - the failures seem related to path formatting. Will approve once addressed.

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

sonarcloud · 2024-03-16T18:59:48Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

unit tests have been fixed 😋

traeok

Sorry for the delayed follow-up review 😅
Changes look good, tests are now passing, LGTM 👍

Thanks @zFernand0!

github-actions · 2024-03-19T13:59:04Z

Release succeeded for the next branch. 🎉

The following packages have been published:

npm: @zowe/zos-ftp-for-zowe-cli@3.0.0-next.202403191358

_{Powered by Octorelease 🚀}

Prep work for vNext

9ace9a8

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

zFernand0 self-assigned this Mar 4, 2024

zFernand0 added 3 commits March 4, 2024 22:32

adjust first prerelease version and update changelog

8016f6e

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

first round of interface changes

2bd0cdc

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

fix all lint warnings

c0aeb4a

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

github-advanced-security bot found potential problems Mar 5, 2024

View reviewed changes

src/api/CreateDataset.ts

}

if (tempOptions.printAttributes) {

delete tempOptions.printAttributes;

response = TextUtils.prettyJson(tempOptions);

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

The value assigned to response here is unused.

zFernand0 added 3 commits March 5, 2024 18:59

fix all build errors

ba9b195

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

fix all unit tests

b187943

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

fix all integration tests. missing 8 system tests

20836b0

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

zFernand0 changed the title ~~First round of V3 compatibility changes~~ V3 Conformance + zos-node-accessor update Mar 6, 2024

zFernand0 mentioned this pull request Mar 6, 2024

Export all defined interfaces for v2.0.x IBM/zos-node-accessor#100

Closed

zFernand0 requested a review from t1m0thyj March 6, 2024 20:41

zFernand0 added 2 commits March 6, 2024 22:29

fix all system tests and any remaining behavior issues

d97087e

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

update snapshots

98f8f40

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

zFernand0 marked this pull request as ready for review March 7, 2024 14:09

zFernand0 requested review from gejohnston, awharn, traeok, anaxceron and ATorrise March 7, 2024 19:24

update docs

6f5de49

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

zFernand0 requested review from tiantn and std4lqi March 7, 2024 20:46

anaxceron approved these changes Mar 7, 2024

View reviewed changes

README.md Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

zFernand0 marked this pull request as draft March 7, 2024 21:32

gejohnston approved these changes Mar 7, 2024

View reviewed changes

src/api/CoreUtils.ts Outdated Show resolved Hide resolved

zFernand0 mentioned this pull request Mar 7, 2024

Unable to create datasets on vNext zowe/zowe-explorer-vscode#2770

Closed

zFernand0 added 2 commits March 8, 2024 13:32

address VSCE breaking changes

e568aca

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

address PR feedback

e8096a8

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

zFernand0 added 2 commits March 8, 2024 12:10

fix code indentation

37b4f9b

Signed-off-by: Fernando Rijo Cedeno <37381190+zFernand0@users.noreply.github.com>

update readme + remove quotes from deleteDs APIs

0534f8b

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

anaxceron approved these changes Mar 11, 2024

View reviewed changes

zFernand0 mentioned this pull request Mar 13, 2024

feat(v3-zftp): Update the zFTP VSCE with the V3 version of the plug-in zowe/zowe-explorer-vscode#2783

Merged

16 tasks

add downloadspoolcontent

f584d5d

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

traeok previously requested changes Mar 14, 2024

View reviewed changes

zFernand0 added 3 commits March 15, 2024 18:16

export zosNodeAccessor as zna

1dd3d5f

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

update exports

1e925e6

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

remove jenkinsfile.old

79708fd

Signed-off-by: zFernand0 <37381190+zFernand0@users.noreply.github.com>

zFernand0 marked this pull request as ready for review March 18, 2024 15:00

zFernand0 requested a review from traeok March 18, 2024 15:00

This was linked to issues Mar 18, 2024

Zowe v3: @zowe-zos-ftp-for-zowe-cli should use zos-node-accessor@2.x #133

Closed

Update the plug-in to be compatible with Zowe CLI V3 and achieve Zowe V3 conformance #153

Closed

traeok approved these changes Mar 19, 2024

View reviewed changes

zFernand0 merged commit 1f5419d into next Mar 19, 2024
18 checks passed

zFernand0 deleted the prep/next branch March 19, 2024 13:50

github-actions bot added the released label Mar 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V3 Conformance + `zos-node-accessor` update #155

V3 Conformance + `zos-node-accessor` update #155

zFernand0 commented Mar 4, 2024 •

edited

Loading

codecov-commenter commented Mar 5, 2024 •

edited

Loading

anaxceron left a comment

gejohnston left a comment

anaxceron left a comment

traeok left a comment

sonarcloud bot commented Mar 16, 2024

traeok left a comment

github-actions bot commented Mar 19, 2024

V3 Conformance + zos-node-accessor update #155

V3 Conformance + zos-node-accessor update #155

Conversation

zFernand0 commented Mar 4, 2024 • edited Loading

codecov-commenter commented Mar 5, 2024 • edited Loading

Codecov Report

anaxceron left a comment

Choose a reason for hiding this comment

gejohnston left a comment

Choose a reason for hiding this comment

anaxceron left a comment

Choose a reason for hiding this comment

traeok left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Mar 16, 2024

Quality Gate passed

traeok left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 19, 2024

V3 Conformance + `zos-node-accessor` update #155

V3 Conformance + `zos-node-accessor` update #155

zFernand0 commented Mar 4, 2024 •

edited

Loading

codecov-commenter commented Mar 5, 2024 •

edited

Loading