Fix sample workflow for publishing to npm

[t1m0thyj]

What It Does

How to Test

Review Checklist
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

Additional Comments

[zFernand0]

LGTM! 😋
Should we have a v1 tag?

[zFernand0]

LGTM! 😋
Should we have a v1 tag?

[t1m0thyj]

LGTM! 😋 Should we have a v1 tag?

Good question 😋 I'm leaning towards no, because it would require additional effort to keep the tag up-to-date and I don't think there would be much benefit unless we anticipate having to make breaking changes to this workflow. Do you think that we might?

[zFernand0]

LGTM! 😋 Should we have a v1 tag?

Good question 😋 I'm leaning towards no, because it would require additional effort to keep the tag up-to-date and I don't think there would be much benefit unless we anticipate having to make breaking changes to this workflow. Do you think that we might?

not for this workflow specifically 😋
we should be fine.
but that brings up another question. should the tagging be automated such that if there is a non-major version bump, the vX gets automatically updated as well?

[t1m0thyj]

LGTM! 😋 Should we have a v1 tag?

Good question 😋 I'm leaning towards no, because it would require additional effort to keep the tag up-to-date and I don't think there would be much benefit unless we anticipate having to make breaking changes to this workflow. Do you think that we might?

not for this workflow specifically 😋 we should be fine. but that brings up another question. should the tagging be automated such that if there is a non-major version bump, the vX gets automatically updated as well?

Good idea, I've had to do that process manually for Octorelease twice this week 😋 I'll create an issue in that repo to investigate automating it.