Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List defined systems #348

Merged
merged 20 commits into from May 1, 2019

Conversation

@uzust01
Copy link
Contributor

commented Apr 26, 2019

Add list systems to zosmf group:

  • zowe zosmf list systems

uzust01 added some commits Apr 23, 2019

Add handler and definitions
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Edit zosmf command group definition unit test
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Change output format to table
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Remove unnecessary comma
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Remove unnecessary imports
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Add integration tests
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Add comma
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Add definitions and handler unit tests, generate snapshots
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Fix typo in status.definition unit test
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Update snapshot for zosmf command group
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Update snapshot for list systems help
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Add command system tests and scripts
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Edit command descriptions and examples
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Update unit tests' snaps
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Update integration tests' snaps
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
testName: "zos_list_systems"
});

systemProps = new TestProperties(testEnvironment.systemTestProperties);

This comment has been minimized.

Copy link
@ChrisBoehmCA

ChrisBoehmCA Apr 26, 2019

Contributor

Hi,

You will have to update this slightly because of #332

use host = testEnvironment.systemTestProperties.zosmf.host; instead of this new TestProperties syntax

// Create the unique test environment
beforeAll(async () => {
testEnvironment = await TestEnvironment.setUp({
testName: "zos_list_systems_integration"

This comment has been minimized.

Copy link
@ChrisBoehmCA

ChrisBoehmCA Apr 26, 2019

Contributor

Please add skipProperties: true here

uzust01 added some commits Apr 26, 2019

Change tests
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Change tests some more
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
Add jesMemberName to output table, update snapshot
Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
@ChrisBoehmCA

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Hi,

Cool command! Worked for me

I think having the message "Number of retreived system definitions:" is not consistent with other commands. Also there is a typo (retreived -> retrieved). @tucker01 and I think it should probably be removed and we should just display the results of the query like list jobs does.

Remove declaration for number or retreived wfs, update tests, rename …
…subdir

Signed-off-by: Uzunov <stanko.uzunov@broadcom.com>
@ChrisBoehmCA
Copy link
Contributor

left a comment

Thanks for removing the message. Looks good to me

@zFernand0 zFernand0 merged commit 45cdeff into zowe:lts-incremental May 1, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
DCO DCO
Details

zFernand0 added a commit that referenced this pull request May 1, 2019

Merge pull request #353 from muzikovam/MSTR-List-defined-systems
Port List defined systems to master (almost** matches #348)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.