Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added return code to ssh command (same as #358) #359

Merged
merged 9 commits into from May 3, 2019

Conversation

@ChrisPark89
Copy link
Contributor

commented Apr 30, 2019

Same update as #358.

matthewpwilson and others added some commits Apr 17, 2019

Use stream.write() so output works on Windows
Signed-off-by: Matthew Wilson <matthew.wilson@uk.ibm.com>
Add return code for ssh command
Signed-off-by: Jeonghyuk Park <jeonghyukpark@jeonghyuks-mbp.hursley.uk.ibm.com>
Added return code feature
Signed-off-by: Jeonghyuk Park <jeonghyukpark@jeonghyuks-mbp.hursley.uk.ibm.com>
Cleaned up the code
Signed-off-by: Jeonghyuk Park <jeonghyukpark@jeonghyuks-mbp.hursley.uk.ibm.com>
Modify return code logic using ssh2 module's return code
Signed-off-by: Jeonghyuk Park <jeonghyukpark@Jeonghyuks-MBP.connect>
Remove endCmdFlag as it's not used any more
Signed-off-by: Jeonghyuk Park <jeonghyukpark@jeonghyuks-mbp.hursley.uk.ibm.com>

@ChrisPark89 ChrisPark89 changed the title Added return code to ssh command Added return code to ssh command (same as #358) Apr 30, 2019

Change ssh profile to optional
Signed-off-by: Chris Park <ganggiyam@gmail.com>
@ChrisBoehmCA
Copy link
Contributor

left a comment

Same as #358

@ghost ghost assigned zFernand0 May 2, 2019

@ghost ghost added the review label May 2, 2019

@zFernand0 zFernand0 removed their assignment May 2, 2019

@zFernand0

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

Same as: #358 (comment)_

Unit test changed so that no longer requires ssh profile
Signed-off-by: Chris Park <ganggiyam@gmail.com>

@zFernand0 zFernand0 merged commit b298deb into zowe:lts-incremental May 3, 2019

1 check failed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details

@ghost ghost removed the review label May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.